Actions
Bug #5096
closed[Workbench] Avoid passing manifest_text around the network too much when updating and merging large collections.
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Story points:
0.5
Description
Examples:
- Workbench should not send manifest_text to API in an update() request when only name/description is being changed (this should be easy enough to achieve in Workbench)
- Cases where the content is being modified probably depend on #5104
- Follow up all related bugs to find out whether this fixes them.
- Close the ones that are fixed.
- Move the rest to bug triage, to find out what's still wrong.
Related issues
Updated by Tom Clegg almost 10 years ago
- Description updated (diff)
- Category set to Workbench
Updated by Tom Clegg almost 10 years ago
- Description updated (diff)
- Story points changed from 1.0 to 0.5
Updated by Radhika Chippada almost 10 years ago
- Assigned To set to Radhika Chippada
Updated by Radhika Chippada almost 10 years ago
- Status changed from New to In Progress
Updated by Brett Smith almost 10 years ago
Reviewing 23c1bc6
When we're doing small updates, the new update method skips a lot of the encoding work in the ApplicationController's implementation, and then repeats a lot of the rendering code. I think we could help future-proof this by repeating as little as possible, and calling super as early as possible. I think you could do it like this:
def update
@updates ||= params[@object.resource_param_name.to_sym]
if @updates && (@updates.keys - ["name", "description"]).empty?
# exclude manifest_text since only name or description is being updated
@object.manifest_text = nil
end
super
end
Let me know what you think of that. Thanks.
Updated by Radhika Chippada almost 10 years ago
Brett, thanks for the suggestion. This is much more efficient and accomplishes the goal more effectively. I made this update.
Updated by Ward Vandewege almost 10 years ago
- Target version changed from 2015-02-18 sprint to 2015-03-11 sprint
Updated by Ward Vandewege over 9 years ago
- Target version changed from 2015-03-11 sprint to 2015-04-01 sprint
Updated by Ward Vandewege over 9 years ago
- Status changed from In Progress to Resolved
Actions