[Workbench] Use full text search instead of 'ilike' when searching with a user-entered query
#4 Updated by Brett Smith over 5 years ago
Reviewing 31e1554. Just one small thing: a couple of pipeline instance integration tests switched from using
visit page_with_token('active_trustedclient') to
visit page_with_token('active'). I'm not sure I see the reason for this change. Using active_trustedclient actually makes the tests work more like production (Workbench is usually considered a "trusted" client), so that's not an issue. Is it possible you meant to consolidate these to say
visit page_with_token('active_trustedclient', 'URL_STRING')? That's a change you made in other tests in this file, and it does save a little test time.
That said, it's not a big deal, I just would rather avoid a possible edit war over things like this if there's no functional reason. I'm happy for this to be merged with or without a change. Thanks.