Feature #5110

[Workbench] Use full text search instead of 'ilike' when searching with a user-entered query

Added by Tom Clegg over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
02/06/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Subtasks

Task #5161: Review branch: 4523-full-text-searchResolvedTom Clegg

Task #5184: Review branch: 5110-workbench-full-text-searchResolvedRadhika Chippada

Associated revisions

Revision b80db28c
Added by Radhika Chippada over 5 years ago

closes #5110
Merge branch '5110-workbench-full-text-search'

History

#1 Updated by Tom Clegg over 5 years ago

  • Subject changed from [Workbench] Use full text search instead of 'like' to [Workbench] Use full text search instead of 'like' and 'ilike'
  • Category set to Workbench

#2 Updated by Radhika Chippada over 5 years ago

  • Assigned To set to Radhika Chippada

#3 Updated by Tom Clegg over 5 years ago

  • Subject changed from [Workbench] Use full text search instead of 'like' and 'ilike' to [Workbench] Use full text search instead of 'ilike' when searching with a user-entered query

#4 Updated by Brett Smith over 5 years ago

Reviewing 31e1554. Just one small thing: a couple of pipeline instance integration tests switched from using visit page_with_token('active_trustedclient') to visit page_with_token('active'). I'm not sure I see the reason for this change. Using active_trustedclient actually makes the tests work more like production (Workbench is usually considered a "trusted" client), so that's not an issue. Is it possible you meant to consolidate these to say visit page_with_token('active_trustedclient', 'URL_STRING')? That's a change you made in other tests in this file, and it does save a little test time.

That said, it's not a big deal, I just would rather avoid a possible edit war over things like this if there's no functional reason. I'm happy for this to be merged with or without a change. Thanks.

#5 Updated by Radhika Chippada over 5 years ago

  • Status changed from New to Resolved

Applied in changeset arvados|commit:b80db28cdd536077e5effe6c08af079532c2059b.

Also available in: Atom PDF