Project

General

Profile

Actions

Bug #5135

closed

[Workbench] Ensure modal button order is consistent

Added by Brett Smith almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Story points:
0.5

Description

These modals have the primary button first from the right:

  • application/_choose.html.erb
  • application/_report_issue_popup.html.erb
  • projects/_choose.html.erb

These modals have the primary button first from the left:

  • jobs/_rerun_job_with_options_popup.html.erb
  • pipeline_instances/show.html.erb (two primary buttons)
  • users/_add_ssh_key_popup.html.erb
  • users/_setup_popup.html.erb
Pick which direction we prefer and make all modals follow it.
  • We prefer to do it like the Bootstrap examples: primary button(s) on the right.
  • I think it's OK to have multiple primary buttons per modal. (This might be friendlier as a single "Copy" button, with a default-unchecked checkbox "run the new pipeline right away". If you forget to check the box, you can hit Run on the next page, so no biggie. But this change doesn't seem especially urgent.)
Actions #1

Updated by Brett Smith almost 10 years ago

  • Subject changed from [Workbench] Modal button order is inconsistent to [Workbench] Ensure modal button order is consistent
  • Category set to Workbench
  • Story points set to 0.5
Actions #2

Updated by Brett Smith almost 10 years ago

  • Description updated (diff)
Actions #3

Updated by Brett Smith almost 10 years ago

  • Description updated (diff)
Actions #4

Updated by Tom Clegg almost 10 years ago

  • Description updated (diff)
Actions #5

Updated by Tom Clegg almost 10 years ago

  • Target version changed from Bug Triage to 2015-03-11 sprint
Actions #6

Updated by Brett Smith almost 10 years ago

  • Status changed from New to In Progress
  • Assigned To set to Brett Smith
  • Target version changed from 2015-03-11 sprint to 2015-02-18 sprint
Actions #7

Updated by Brett Smith almost 10 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:e20040092b47f79365637dd8e26156d95ab5c6ee.

Actions

Also available in: Atom PDF