Bug #5160

[API] Non-admin can't share a project publicly on qr1hi

Added by Brett Smith over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
API
Target version:
Start date:
02/06/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.50 h)
Story points:
0.5

Description

When you try, the modal reports an error that the tail UUID …-anonymouspublic could not be found.

At first glance, It looks like the database isn't seeded with permission for all users to see the anonymous public group.


Subtasks

Task #5163: Review 5160-share-with-anonymous-group-wipResolvedBrett Smith

Associated revisions

Revision 0215bf7b
Added by Brett Smith over 5 years ago

Merge branch '5160-share-with-anonymous-group-wip'

Closes #5160, #5163.

History

#1 Updated by Ward Vandewege over 5 years ago

  • Story points set to 0.5

#2 Updated by Radhika Chippada over 5 years ago

Review comments:

  • Everything looks good and worked as expected (except the below concern)
  • I am quite concerned about the user experience. A user can share a project with anonymous users using workbench. However, this is doable even when anonymous browsing is not enabled. I think this will be quite confusing to an end user (especially now that it will be open to “all” users). I think we should not include the anonymous group and anonymous user in the sharing popup selections when anonymous browsing is not enabled.

#3 Updated by Brett Smith over 5 years ago

Radhika Chippada wrote:

  • I am quite concerned about the user experience. A user can share a project with anonymous users using workbench. However, this is doable even when anonymous browsing is not enabled. I think this will be quite confusing to an end user (especially now that it will be open to “all” users). I think we should not include the anonymous group and anonymous user in the sharing popup selections when anonymous browsing is not enabled.

Done in f102390c and ready for another look. Thanks.

#4 Updated by Radhika Chippada over 5 years ago

Brett, thanks for the update. Looks very good as far as sharing with groups is concerned.

Do we also want remove the "anonymous user" from the "share with users" selection list? It is true that the anonymous user is only included in the list for admin users and hence is not as big a deal as the groups with inactive user support. Your call since it is for admin users only.

Thanks. Everything else LGTM.

#5 Updated by Brett Smith over 5 years ago

Radhika Chippada wrote:

Do we also want remove the "anonymous user" from the "share with users" selection list? It is true that the anonymous user is only included in the list for admin users and hence is not as big a deal as the groups with inactive user support. Your call since it is for admin users only.

Radhika,

I agree that this would be nice, but I also agree that it's lower priority, since only admins see it, and it's not the documented way to share things. Because the original bug here is blocking use of the sharing feature in general, and was reported by users, I've gone ahead and merged the branch in its current state. I encourage you to file a new bug to keep separate track of this suggestion. I'm hopeful that, before we get to that, or as part of the work of implementing it, we can improve the filtering options a bit, so that we don't have to rely on checking free text fields like I did for the first round.

Thanks.

#6 Updated by Brett Smith over 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:0215bf7b8c61d59462a476d850af999105856177.

Also available in: Atom PDF