Arvados

Best fix for this is probably to use the new SDK from #5104.

Looks like this is a bug in Keep#files in source:sdk/ruby/lib/arvados/keep.rb#L164 -- each_file_spec provides [stream_name, pos, size, filename] and #files needs to split filename by '/' and move the dir parts onto streamname in order to consistently return [dirname, basename, size] regardless of whether streams===dirs.

(Obviously need a test case for this too!)

Implementation notes:

• Updated Keep#files method as per Tom's note. Added test fixture and test.

• Updated workbench Gemfile* to use the newer gem version. (Note: Please let me know if I did not get this right. Thanks.)

• Manual test performed on the collection qr1hi-4zz18-4ea12pbiq1zaf08 and it now displays directory structure. And the files in directories are viewable and downloadable (#5682)

comments on 5179-dirs-in-filenames @ 17e59fe

Code looks good. (The "rpartition" threw me off for a bit by using the "/" from "dir1/file1" to build the "./dir1" string... but then I got it.)

I think it would be worthwhile to add a test case like this:

. #{random_block(10)} 0:3:file1 3:3:dir1/file1 6:4:dir1/dir2/file1
./dir1 #{random_block(10)} 0:3:file1 3:7:dir2/file1

→ check that manifest.files contains ["./dir1", "file1", 6] and ["./dir1/dir2", "file1", 11]

Unfortunately this will mean doing the Gemfile.lock thing over again. If that's too painful, and assuming the actual sdk code doesn't have to change to make that test pass (as I suspect) you could merge 17e59fe and then add this test in another commit after jenkins has had a chance to build/publish the 0.1.20150419022214 package.