Bug #5183

[Workbench] Job reuse modal test fails intermittently

Added by Brett Smith about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
02/09/2015
Due date:
% Done:

0%

Estimated time:
Story points:
-

Description

This is the error when it happens:

  1) Error:
JobsTest#test_Rerun_job_with_latest_version_job,_expect_options_true,_and_use_latest_version_option_true:
Capybara::ExpectationNotMet: expected to find text "Script version master does not resolve to a commit" in "workbench:test active-user@arvados.local Dashboard Projects Home Oh... fiddlesticks. An error occurred when Workbench sent a request to the Arvados API server. Try reloading this page. If the problem is temporary, your request might go through next time. If that doesn't work, the information below can help system administrators track down the problem. API request URL https://0.0.0.0:34465/arvados/v1/jobs API response { \":errors\":[ \"Script version 7def43a4d3f20789dda4700f703b5514cc3ed250 does not resolve to a commit\" ], \":error_token\":\"1423522789+1d2293e4\" } If you suspect this is a bug, you can help us fix it by sending us a problem report: Send a problem report right here. Report problem If you prefer, send email to: arvados@example.com" 
    test/integration/jobs_test.rb:110:in `block (2 levels) in <class:JobsTest>'
    test/test_helper.rb:236:in `run'

The test submits a job with script_version: master, and expects the error message to refer to "master" as well. But it's being resolved to a specific commit hash.

workbench-fail-1.png (73.9 KB) workbench-fail-1.png JobsTest#test_Rerun_foobar_job,_expect_options_false,_and_use_latest_version_option_false Tom Clegg, 02/10/2015 06:11 PM
workbench-fail-2.png (84.3 KB) workbench-fail-2.png JobsTest#test_Rerun_job_with_latest_version_job,_expect_options_true,_and_use_latest_version_option_false Tom Clegg, 02/10/2015 06:11 PM
workbench-fail-3.png (87.8 KB) workbench-fail-3.png JobsTest#test_Rerun_job_with_latest_version_job,_expect_options_true,_and_use_latest_version_option_true Tom Clegg, 02/10/2015 06:11 PM

Associated revisions

Revision 67a48253 (diff)
Added by Tom Clegg about 5 years ago

5183: Disable animation on modal. (It seems to cause intermittent test failures.) refs #5183

Revision b599ef92 (diff)
Added by Tom Clegg about 5 years ago

Fix javascript errors when closing modal. refs #5183

History

#1 Updated by Radhika Chippada about 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada

#2 Updated by Tom Clegg about 5 years ago

I suspect the modal is still animating (moving down the page) when capybara chooses a coordinate to click and then clicks. Therefore, the wrong radio button gets selected.

Noticing...
  • If you do, in fact, select "use the latest master" and the error message is "{sha1} cannot be resolved" then the error message is wrong (even if it states something that is true).
  • If master resolves to a sha1, and that sha1 cannot be resolved, then something in/near git is broken.
  • This test failure is inconsistent. (It's not OK for the behavior being tested to be inconsistent!)

#4 Updated by Tom Clegg about 5 years ago

Above screenshots are with

      assert_triggers_dom_event 'shown.bs.modal' do
        find('a,button', text: 'Re-run job...').click
      end
      within('.modal-dialog') do
        assert_selector 'a,button', text: 'Cancel'
        if use_latest
          page.choose("job_script_version_#{job['supplied_script_version']}")
        end
        screenshot
        click_on "Run now" 
      end

#5 Updated by Tom Clegg about 5 years ago

  • Status changed from In Progress to Resolved
  • Target version changed from Bug Triage to 2015-02-18 sprint

Also available in: Atom PDF