Bug #5185

[Workbench] Project lists all collections as zero size as of 6bf9ae1

Added by Ward Vandewege over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
02/11/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

In projects, all collections are listed as "0 bytes Collection". Visible on 4xphq and su92l, for example:

https://workbench.su92l.arvadosapi.com/projects/su92l-j7d0g-1d2se4f08r0q7ta

Subtasks

Task #5195: Review branch: 5185-collections-tab-zero-size-issueResolvedTom Clegg

Associated revisions

Revision 5d3d32d5
Added by Radhika Chippada over 5 years ago

closes #5185
Merge branch '5185-collections-tab-zero-size-issue'

History

#1 Updated by Ward Vandewege over 5 years ago

  • Subject changed from Project and collection viewing busted as of 6bf9ae1 to [Workbench] Project and collection viewing busted as of 6bf9ae1

#2 Updated by Ward Vandewege over 5 years ago

  • Description updated (diff)

#3 Updated by Ward Vandewege over 5 years ago

  • Description updated (diff)

#4 Updated by Ward Vandewege over 5 years ago

  • Subject changed from [Workbench] Project and collection viewing busted as of 6bf9ae1 to [Workbench] Project lists all collections as zero size as of 6bf9ae1
  • Description updated (diff)

#5 Updated by Ward Vandewege over 5 years ago

  • Description updated (diff)

#6 Updated by Radhika Chippada over 5 years ago

This may be due to the work from #4464 (where manifest text is omitted while loading projects -> Data collections tab).

I went back to my local version of the branch used to review this branch (at 7c5a88d) and see the issue there as well.

Sorry I did not notice this issue during the review phase of this branch.

#7 Updated by Radhika Chippada over 5 years ago

Tom said on IRC:

12:11 tomclegg: I'm inclined to say 5185 should be: step 1. Don't say "0 bytes" when we don't have the information, just leave that column blank. step 2. With full text search we can make the "list of files" attr complete, instead of truncating it; and we can add sizes to it while we're at it. Caching the total data size seems like a good idea, following the same pattern as the computed "list of files" attr.
12:12 tomclegg: When API offers that attr, workbench should request it, and use that to display the collection size.
12:13 tomclegg: But yes, I think we should do the trivial fix now. It's too bad we lose the file size but I think that's better than super-slow/timing-out page loading, in the interim.

#8 Updated by Radhika Chippada over 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-02-18 sprint

#9 Updated by Radhika Chippada over 5 years ago

Implemented Step 1: if description is available, display it in the description column; otherwise display the modified time.

#10 Updated by Radhika Chippada over 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:5d3d32d5532d39f1ef85a9e01b9b70cd28cf3579.

Also available in: Atom PDF