Project

General

Profile

Actions

Bug #5186

closed

[Workbench] Collection viewing broken for collections with empty (but non-nil) properties attribute

Added by Ward Vandewege almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Story points:
0.5

Description

I have a collection (su92l-4zz18-kf7cytopq8suzi0) with a properties attribute that has the value {}. I was able to set the properties attribute to {} with the Python SDK.

Viewing this collection leads to a fiddlesticks error:

Started GET "/collections/su92l-4zz18-kf7cytopq8suzi0" for 207.172.212.131 at 2015-02-11 01:01:51 +0000
Processing by CollectionsController#show as HTML
  Parameters: {"id"=>"su92l-4zz18-kf7cytopq8suzi0"}
  Rendered collections/_show_source_summary.html.erb (0.1ms)
  Rendered collections/_sharing_button.html.erb (0.6ms)
  Rendered application/_title_and_buttons.html.erb (1.7ms)
  Rendered application/show.html.erb (2.9ms)
  Rendered collections/show.html.erb within layouts/application (12.7ms)
#<TypeError: no implicit conversion of Symbol into Integer>
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/app/views/application/_title_and_buttons.html.erb:3:in `[]'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/app/views/application/_title_and_buttons.html.erb:3:in `block in _app_views_application__title_and_buttons_html_erb__42221069618551823_60261440'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/vendor/bundle/ruby/2.1.0/gems/actionview-4.1.9/lib/action_view/helpers/capture_helper.rb:38:in `block in capture'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/vendor/bundle/ruby/2.1.0/gems/actionview-4.1.9/lib/action_view/helpers/capture_helper.rb:200:in `with_output_buffer'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/vendor/bundle/ruby/2.1.0/gems/actionview-4.1.9/lib/action_view/helpers/capture_helper.rb:38:in `capture'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/vendor/bundle/ruby/2.1.0/gems/actionview-4.1.9/lib/action_view/helpers/capture_helper.rb:152:in `content_for'
/var/www/workbench.su92l.arvadosapi.com/releases/20150211005436/app/views/application/_title_and_buttons.html.erb:2:in `_app_views_application__title_and_buttons_html_erb__42221069618551823_60261440'

This is line 3 in app/views/application/_title_and_buttons.html.erb:

    <%= (@object.respond_to?(:properties) and !@object.properties.nil? ? @object.properties[:page_title] : nil) ||

Subtasks 1 (0 open1 closed)

Task #5221: Review branch: 5186-collection-with-empty-propertiesResolvedRadhika Chippada02/15/2015Actions
Actions

Also available in: Atom PDF