Bug #5220

[Workbench] for collections shared anonymously, do not show the 'Sharing and Permissions' box

Added by Ward Vandewege about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
02/16/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

It just shows "Your API token is not authorized to manage collection sharing links.".

Quick fix: remove the box.

If there's time (but this is an urgent story), that space would be a nice spot for some boilerplate text that explains users can create an Arvados account to do something with the data.


Subtasks

Task #5225: Review branch: 5220-no-sharing-box-for-anon-userResolvedWard Vandewege

Associated revisions

Revision d54738ad
Added by Radhika Chippada about 5 years ago

closes #5220
Merge branch '5220-no-sharing-box-for-anon-user'

History

#1 Updated by Ward Vandewege about 5 years ago

  • Description updated (diff)

#2 Updated by Brett Smith about 5 years ago

For background, Workbench used to be quieter in this scenario. The message was added during review of #4291 as a debugging aid. Presumably we still want to show it, or something like it, except in the very specific case that we're using the anonymous browsing token.

#3 Updated by Ward Vandewege about 5 years ago

Brett Smith wrote:

For background, Workbench used to be quieter in this scenario. The message was added during review of #4291 as a debugging aid. Presumably we still want to show it, or something like it, except in the very specific case that we're using the anonymous browsing token.

Yeah, that's right. Anonymous users don't know they have tokens, so it's just confusing.

#4 Updated by Radhika Chippada about 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-02-18 sprint

#5 Updated by Radhika Chippada about 5 years ago

Notes about the update:

  • I hid the "Sharing and permissions" box when anonymous access is the context.
  • I showed a "Welcome to Arvados" panel with the message "You are accessing public data" in the empty space; it looked pretty bad with the empty space otherwise.
  • If there is a specific text we want to display in this panel, please let me know and I will make the update right away.

#6 Updated by Ward Vandewege about 5 years ago

I added one whitespace cleanup commit on this branch, thanks, LGTM.

Please pull in that commit and merge!

#7 Updated by Radhika Chippada about 5 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:d54738ad3b2fde0207cf1ebbdc6f4360cd141d90.

Also available in: Atom PDF