Project

General

Profile

Actions
Copy link

Bug #5220

closed

[Workbench] for collections shared anonymously, do not show the 'Sharing and Permissions' box

Added by Ward Vandewege almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
2015-02-18 sprint
Story points:
0.5

Description

It just shows "Your API token is not authorized to manage collection sharing links.".

Quick fix: remove the box.

If there's time (but this is an urgent story), that space would be a nice spot for some boilerplate text that explains users can create an Arvados account to do something with the data.

Subtasks 1 (0 open — 1 closed)

Task #5225: Review branch: 5220-no-sharing-box-for-anon-userResolvedWard Vandewege02/16/2015Actions
Actions
Copy link
 #1

Updated by Ward Vandewege almost 10 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Brett Smith almost 10 years ago

For background, Workbench used to be quieter in this scenario. The message was added during review of #4291 as a debugging aid. Presumably we still want to show it, or something like it, except in the very specific case that we're using the anonymous browsing token.

Actions
Copy link
 #3

Updated by Ward Vandewege almost 10 years ago

Brett Smith wrote:

For background, Workbench used to be quieter in this scenario. The message was added during review of #4291 as a debugging aid. Presumably we still want to show it, or something like it, except in the very specific case that we're using the anonymous browsing token.

Yeah, that's right. Anonymous users don't know they have tokens, so it's just confusing.

Actions
Copy link
 #4

Updated by Radhika Chippada almost 10 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-02-18 sprint
Actions
Copy link
 #5

Updated by Radhika Chippada almost 10 years ago

Notes about the update:

  • I hid the "Sharing and permissions" box when anonymous access is the context.
  • I showed a "Welcome to Arvados" panel with the message "You are accessing public data" in the empty space; it looked pretty bad with the empty space otherwise.
  • If there is a specific text we want to display in this panel, please let me know and I will make the update right away.
Actions
Copy link
 #6

Updated by Ward Vandewege almost 10 years ago

I added one whitespace cleanup commit on this branch, thanks, LGTM.

Please pull in that commit and merge!

Actions
Copy link
 #7

Updated by Radhika Chippada almost 10 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:d54738ad3b2fde0207cf1ebbdc6f4360cd141d90.

Actions
Copy link

Also available in: Atom PDF