Bug #5523
open
[Crunch] crunchstat should not report errors during normal timing races
Added by Peter Amstutz almost 10 years ago.
Updated 10 months ago.
Release relationship:
Auto
Description
Container stat files appear and disappear in normal operation. In the "normal" cases, such events should not be logged (let alone as an error).
We expect zero or one episode of "cannot find stats file" when cidfile != "" and we're collecting stats for the first time.
- If the first collection attempt for a given statistic results in "cannot find file", we should block in OpenStatFile and poll quickly over a short interval (say, every 100ms, max 1s) because we probably just won the race with the container setup process.
- If the stat files don't show up within that max interval (~1s) it means something is wrong, and this should (still) be logged.
We expect zero or one episode of "stats file disappeared" when cidfile != "" when we happen to poll between container shutdown and (crunchstat's) child exit. For a given statistic:
- The first time this occurs, we should not log anything.
- The second time this occurs, we should log "warning: stats file disappeared {duration} ago, but child has not exited".
- The third+ time this occurs, we should not log anything.
- If the stat file reappears, we should reset the "went missing" counter to zero.
- Target version changed from Bug Triage to Arvados Future Sprints
Would be good to have more detail - job ID or log fragment.
We could probably start by changing that message to say "warning".
- Target version changed from Arvados Future Sprints to 2015-05-20 sprint
- Status changed from New to In Progress
- Category set to Crunch
- Assigned To set to Tom Clegg
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:200f7004f921a68ec40b407dfe31f1db95e98fb9.
- Subject changed from [Crunch] crunchstat The "error reading stats from /sys/fs/cgroup/memory/memory.stat to [Crunch] crunchstat should not report errors during normal timing races
- Description updated (diff)
- Status changed from Resolved to In Progress
Reopening to add TODO from #4882.
- Status changed from In Progress to New
- Target version changed from 2015-05-20 sprint to Arvados Future Sprints
- Target version deleted (
Arvados Future Sprints)
- Target version set to Future
Also available in: Atom
PDF