Actions
Bug #5626
closed
[API] Configuration option to set git server hostname
Story points:
0.5
Description
In current master, the hostname for the git server is always git.(uuid_prefix).arvadosapi.com. The git server hostname should be configurable to support alternate arvados installations (such as the docker containers).
Updated by Peter Amstutz about 9 years ago
- Subject changed from [Docker] Default fetch_url and push_url is wrong for docker containers. to [API] Configuration option to set git server hostname
- Assigned To set to Peter Amstutz
Updated by Peter Amstutz about 9 years ago
- Target version changed from Bug Triage to 2015-04-29 sprint
Updated by Peter Amstutz about 9 years ago
- Status changed from New to In Progress
- Story points set to 0.5
Updated by Radhika Chippada about 9 years ago
Peter,
Took a quick look at this update.
- Is it possible to write tests? Toggle the config setting and do a get on the repo and verify the fetch and push urls?
- Also, can you please add some explanation of what and why. I felt that original (overwritten) subject gave me more background on this.
Thanks.
Updated by Radhika Chippada about 9 years ago
Peter,
Thanks for the updated tests. Just one more comment about the test.
- Can you also verify the push url in the test? Even though it is the same as fetch url, I think it would help verify in the test.
- Would you please update the test to verify the url(s) with and without the config param? Even though the default (false) setting is implicitly already tested in other tests, having the two of them together will help visualize the differences better. Something as follows?
[
"example.com",
false
].each do |set_git_host|
test "set git_host #{set_git_host} and verify fetch and push urls" do
...
Updated by Peter Amstutz about 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:8053949c0bd853f9e6d342dbda504766bd3120a1.
Actions