Feature #5645

[Workbench] Social media optimize anonymous collections/projects/pipelines

Added by Nancy Ouyang over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
05/12/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

everyone wants to share their cool datasets on social media, right? :)

This is how Google+ generates those previews:

https://developers.google.com/+/web/snippet/

And for Facebook, we want some 'open graph' meta tags:

https://developers.facebook.com/docs/sharing/best-practices#tags

Looks like Google+ supports open graph too.

SEO-arvados-facebook.png (39.5 KB) SEO-arvados-facebook.png Nancy Ouyang, 04/02/2015 06:25 PM

Subtasks

Task #6001: Review branch: 5645-open-graph-meta-tagsResolvedRadhika Chippada


Related issues

Precedes (1 day) Arvados - Bug #6174: [Workbench] Propagate old search engine meta tags in sync with Open Graph dataNew05/14/201505/14/2015

Associated revisions

Revision 01574a90
Added by Radhika Chippada over 6 years ago

closes #5645
Merge branch '5645-open-graph-meta-tags'

History

#1 Updated by Ward Vandewege over 6 years ago

  • Description updated (diff)

#2 Updated by Ward Vandewege over 6 years ago

  • Target version set to Bug Triage

#3 Updated by Ward Vandewege over 6 years ago

  • Subject changed from Social media optimize anonymous collections/projects/pipelines to [Workbench] Social media optimize anonymous collections/projects/pipelines

#4 Updated by Brett Smith over 6 years ago

  • Category set to Workbench
  • Target version changed from Bug Triage to Arvados Future Sprints

#5 Updated by Ward Vandewege over 6 years ago

  • Target version changed from Arvados Future Sprints to 2015-05-20 sprint

#6 Updated by Tom Clegg over 6 years ago

  • Story points set to 0.5

#7 Updated by Radhika Chippada over 6 years ago

  • Assigned To set to Radhika Chippada

#8 Updated by Radhika Chippada over 6 years ago

Discussed this with Ward this morning and we agreed that:

  • Add open graph meta tags to our pages
  • Add these tags for all objects (since the search engine won't be able to access private data anyways)

#9 Updated by Radhika Chippada over 6 years ago

Implementation notes:

  • Also, manually verified by looking at the loaded page html
  • All existing automated tests passed

#10 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress

#11 Updated by Brett Smith over 6 years ago

1be4d28 is good to merge. I just see a couple of small opportunities to smooth things over for future readers:

  • Expounding the comment about Open Graph with a sentence or two about what it is and why we include it us might be useful for people who don't recognize the name. (I'm not sure I would've known without being able to refer to the background materials you provided in this ticket. Those were very helpful, so thanks.)
  • Why do the conditions rescue exceptions raised by @object.respond_to?. respond_to? is a method that Ruby defines for all objects, so it really should never raise an exception, and I don't see any other places in the Workbench code where we rescue it. These conditions might be easier to follow without those.

But go ahead and merge whether or not you make changes. Thanks.

#12 Updated by Radhika Chippada over 6 years ago

Thanks for reviewing Brett.

  • I expanded the comment to include the feature number and the url, which should greatly help with code maintenance.
  • I removed the "rescue nil" from respond_to? usage.

#13 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:01574a902d99cba21ed53e62cef6bef683bed2a2.

#14 Updated by Nancy Ouyang over 6 years ago

From the sprint review a week ago: we could also consider adding either user-upload(able) "thumbnail" images to the collection/project, or perhaps try to generate one automatically (e.g. the curoverse logo, or some permutation of text on top of the logo with the title or size of the collection or something along those lines) or by default if the user does not select or upload an image.

Also available in: Atom PDF