Project

General

Profile

Actions
Copy link

Bug #5682

closed

[Workbench] Can't view/download files under subdirectories in stream

Added by Bryan Cosca about 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
2015-05-20 sprint
Story points:
-

Description

collection qr1hi-4zz18-tw19sdspe9ljqgk

Files

view_download_files_from_sub.gif (667 KB) view_download_files_from_sub.gif Bryan Cosca, 04/08/2015 02:21 PM

Subtasks 1 (0 open — 1 closed)

Task #5948: Review branch: 5682-download-file-errorResolvedRadhika Chippada05/07/2015Actions

Related issues

Related to Arvados - Bug #5179: [Workbench] [SDKs] Incorrect collection display when stream has entries with subdirectoriesResolvedRadhika Chippada04/19/2015Actions
Has duplicate Arvados - Bug #5909: Cannot see output collection from workbenchClosed05/05/2015Actions
Actions
Copy link
 #1

Updated by Brett Smith about 9 years ago

  • Subject changed from Cannot view/download files within a subdirectory of a collection to [Workbench] Can't view/download files under subdirectories in stream
  • Category set to Workbench
Actions
Copy link
 #2

Updated by Radhika Chippada about 9 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-04-29 sprint
Actions
Copy link
 #3

Updated by Radhika Chippada about 9 years ago

  • Status changed from In Progress to Resolved

Resolved by #5179

Actions
Copy link
 #4

Updated by Brett Smith almost 9 years ago

  • Status changed from Resolved to New
  • Target version changed from 2015-04-29 sprint to Bug Triage

This is not fixed. #5179 only updated the way Keep::Manifest#files works. Workbench uses #has_file? to check whether the file exists.

Probably the logic that was added to #files in #5179 should be moved to #each_file_spec (where #files can use it).

Actions
Copy link
 #5

Updated by Radhika Chippada almost 9 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Radhika Chippada almost 9 years ago

  • Target version changed from Bug Triage to 2015-05-20 sprint
Actions
Copy link
 #7

Updated by Radhika Chippada almost 9 years ago

Moved the logic that checks if a filename has '/' character into each_file_spec method from files method.

Actions
Copy link
 #8

Updated by Peter Amstutz almost 9 years ago

6c63fcb LGTM

I noticed that this also fixes the rendering (files are nested in their folders instead of having part of the path displayed in the file name), so that's great.

Actions
Copy link
 #9

Updated by Radhika Chippada almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:559d26fd819f477fed75201fa952fed19de77f7e.

Actions
Copy link

Also available in: Atom PDF