Bug #5682

[Workbench] Can't view/download files under subdirectories in stream

Added by Bryan Cosca over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
05/07/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

view_download_files_from_sub.gif (667 KB) view_download_files_from_sub.gif Bryan Cosca, 04/08/2015 02:21 PM

Subtasks

Task #5948: Review branch: 5682-download-file-errorResolvedRadhika Chippada


Related issues

Related to Arvados - Bug #5179: [Workbench] [SDKs] Incorrect collection display when stream has entries with subdirectoriesResolved04/19/2015

Has duplicate Arvados - Bug #5909: Cannot see output collection from workbenchClosed05/05/2015

Associated revisions

Revision 559d26fd
Added by Radhika Chippada over 6 years ago

closes #5682
Merge branch '5682-download-file-error'

Revision fdd2d805 (diff)
Added by Radhika Chippada over 6 years ago

refs #5682 : update arvados gem version

History

#1 Updated by Brett Smith over 6 years ago

  • Subject changed from Cannot view/download files within a subdirectory of a collection to [Workbench] Can't view/download files under subdirectories in stream
  • Category set to Workbench

#2 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-04-29 sprint

#3 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Resolved by #5179

#4 Updated by Brett Smith over 6 years ago

  • Status changed from Resolved to New
  • Target version changed from 2015-04-29 sprint to Bug Triage

This is not fixed. #5179 only updated the way Keep::Manifest#files works. Workbench uses #has_file? to check whether the file exists.

Probably the logic that was added to #files in #5179 should be moved to #each_file_spec (where #files can use it).

#5 Updated by Radhika Chippada over 6 years ago

  • Status changed from New to In Progress

#6 Updated by Radhika Chippada over 6 years ago

  • Target version changed from Bug Triage to 2015-05-20 sprint

#7 Updated by Radhika Chippada over 6 years ago

Moved the logic that checks if a filename has '/' character into each_file_spec method from files method.

#8 Updated by Peter Amstutz over 6 years ago

6c63fcb LGTM

I noticed that this also fixes the rendering (files are nested in their folders instead of having part of the path displayed in the file name), so that's great.

#9 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:559d26fd819f477fed75201fa952fed19de77f7e.

Also available in: Atom PDF