Bug #5752

[SDKs] Fix unreliable image timestamp recording in arv keep docker

Added by Brett Smith over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
SDKs
Target version:
Start date:
04/16/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.50 h)
Story points:
0.5

Description

Docker metadata links for Docker image collections should include an image_timestamp property. This helps the API server with job reuse so that if an older image is uploaded after a newer one, it continues to use the newer image to resolve symbolic names, consider it during job reuse decisions, etc.

Recently, arv keep docker has been creating these links without the image_timestamp property. They're usually easy to spot with a query like arv link list --filters='[["link_class", "=", "docker_image_repo+tag"]]'. This is expected behavior if arv keep docker can't get an image's created timestamp from Docker, but we should investigate why this is happening and make the tool more robust in this situation. It's not a simple code regression; some recent links do have the timestamp. It's something more subtle, like an interaction with a specific Docker version or details about how the image was created.


Subtasks

Task #5881: Review 5752-arv-copy-preserve-docker-timestamps-wipResolvedBrett Smith


Related issues

Related to Arvados - Feature #4223: [SDKs] arv keep docker --download to get image from ArvadosClosed04/13/2015

Associated revisions

Revision 73c9a44b
Added by Brett Smith over 6 years ago

Merge branch '5752-arv-copy-preserve-docker-timestamps-wip'

Closes #5752, #5881.

History

#1 Updated by Tom Clegg over 6 years ago

  • Subject changed from [SDKs] arv keep docker saving images without image timestamp to [SDKs] Fix unreliable image timestamp recording in arv keep docker
  • Story points set to 0.5

#2 Updated by Tom Clegg over 6 years ago

  • Target version changed from Bug Triage to 2015-05-20 sprint

#3 Updated by Tom Clegg over 6 years ago

  • Assigned To set to Brett Smith

#4 Updated by Brett Smith over 6 years ago

After investigation, arv-copy seems like a more likely culprit. I found a family of images on su92l which all had the same tag. Some of them had the image_timestamp, and others didn't. That makes me think that the difference is not how in the image is built, but how it's uploaded. I've prepared a branch to teach arv-copy to preserve that data.

#5 Updated by Tom Clegg over 6 years ago

c19ed0b lgtm, thanks

#6 Updated by Brett Smith over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:73c9a44b85ba72e881c5133422fcabe3f1322142.

Also available in: Atom PDF