https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422015-05-18T13:45:08ZArvadosArvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=247552015-05-18T13:45:08ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Target version</strong> changed from <i>Bug Triage</i> to <i>2015-06-10 sprint</i></li></ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=248542015-05-19T19:46:08ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> set to <i>1.0</i></li></ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=249542015-05-20T19:36:56ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=249812015-05-20T20:10:54ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Assigned To</strong> changed from <i>Peter Amstutz</i> to <i>Brett Smith</i></li></ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=255142015-06-03T21:08:15ZBrett Smithbrett.smith@curii.com
<ul></ul><p>5790-copy-most-recent-docker-image-wip is up for review. It ends up revamping the Docker image list function in arv-keepdocker, because that's what arv-copy calls to find what it should copy. I ended up fixing several bugs while I was here. Relevant to arv-copy:</p>
<ul>
<li>The original sorting bug: the code previously used created_at a sort key when image_timestamp was not available. This did not match the API server's behavior, which is to follow links with any image_timestamp before ones without.</li>
<li>Also like API server, ignore links that point to unknown collections.</li>
<li>Always fetch all Docker links, not just the first batch returned by the API server.</li>
<li>Docker images can be referred to by Docker image hash, so I added that search functionality to the list function.</li>
</ul>
<p>Some listing improvements:</p>
<ul>
<li>Show image hashes when listing images by name.</li>
<li>Like Docker itself, when an image has multiple names and we're not filtering by name, list each one.</li>
</ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=255152015-06-03T21:08:31ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=256882015-06-09T14:41:09ZNico César
<ul></ul><p>I finally checked and tested out.</p>
<p>This is a comparison of the output from master and the branch :</p>
<pre>
$ arv-keepdocker
REPOSITORY TAG IMAGE ID COLLECTION CREATED
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa latest d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-1v45jub259sjjgb">zzzzz-4zz18-1v45jub259sjjgb</a> Tue Jun 10 14:30:00 2014
arvados/apitestfixture latest d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-t68oksiu9m80s4y">zzzzz-4zz18-t68oksiu9m80s4y</a> Thu Jun 10 14:30:00 2010
</pre>
<pre>
$ arv-keepdocker
REPOSITORY TAG IMAGE ID COLLECTION CREATED
arvados/apitestfixture latest d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-1v45jub259sjjgb">zzzzz-4zz18-1v45jub259sjjgb</a> Tue Jun 10 14:30:00 2014
arvados/apitestfixture june10 d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-1v45jub259sjjgb">zzzzz-4zz18-1v45jub259sjjgb</a> Tue Jun 10 14:30:00 2014
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa latest d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-1v45jub259sjjgb">zzzzz-4zz18-1v45jub259sjjgb</a> Tue Jun 10 14:30:00 2014
arvados/apitestfixture latest d8309758b8fe <a href="https://arvadosapi.com/zzzzz-4zz18-t68oksiu9m80s4y">zzzzz-4zz18-t68oksiu9m80s4y</a> Thu Jun 10 14:30:00 2010
</pre>
<p>this looks good to me. merge it!</p> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=256902015-06-09T14:55:09ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:e8ae9364dce380d305833f35dfb25578175664d7.</p> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=257492015-06-10T14:53:37ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>In Progress</i></li></ul><p>Looks like this change broke arv keep docker on 4xphq:</p>
<pre>
shell.4xphq:~$ arv keep docker
REPOSITORY TAG IMAGE ID COLLECTION CREATED
Traceback (most recent call last):
File "/usr/local/bin/arv-keepdocker", line 4, in <module>
main()
File "/usr/local/lib/python2.7/dist-packages/arvados/commands/keepdocker.py", line 291, in main
for i, j in list_images_in_arv(api, args.retries):
File "/usr/local/lib/python2.7/dist-packages/arvados/commands/keepdocker.py", line 241, in list_images_in_arv
filters=search_filters + [['link_class', '=', 'docker_image_hash']])
File "/usr/local/lib/python2.7/dist-packages/arvados/commands/keepdocker.py", line 187, in _get_docker_links
links.sort(key=itemgetter('_sort_key'), reverse=True)
TypeError: can't compare datetime.datetime to int
</pre>
<p>If I comment out line 187 (and also line 274 where the same sort is done), then it works again.</p> Arvados - Bug #5790: [SDKs] arv-copy does not select the correct Docker image to copyhttps://dev.arvados.org/issues/5790?journal_id=257552015-06-10T15:30:16ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados|commit:679ea52a117414fc33768aac887615f9b701fdf8.</p>