Bug #5826
closed[Workbench] Pipeline Instance input tab should be more verbose
Description
The user should be able to see which input is not readable, maybe by a red highlight of the input box.
From instance: qr1hi-d1hrv-80zon4obj9ufhvr
Files
Updated by Bryan Cosca over 9 years ago
This is probably related: The "Input your outputname to allelotype" parameter should be a text box. I've fixed it and didn't receive the error anymore.
However this issue should still stand because I tried to run GATK3 here: qr1hi-d1hrv-v3tb1ikn8isbbc5 on my bcosctemp@gmail.com and it still doesn't show which parameters I need to correct in order to run the pipeline.
Updated by Radhika Chippada over 9 years ago
- Category set to Workbench
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
- Target version set to 2015-04-29 sprint
Updated by Radhika Chippada over 9 years ago
I think it is failing because of the following component value:
output_prefix = {:required=>true, :dataclass=>"Collection", :title=>"Input your output name to allelotype", :default=>"test"}
I updated the method unreadable_inputs_present? in pipeline_instances_controller to checkout readable only for a pdh or uuid and the issue is now resolved.
However, do we want to do more such as check it is not "output" or "output_prefix" etc?
Updated by Radhika Chippada over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:8464bb48ba769c8bf0984c8b1493ca43fd902891.
Updated by Radhika Chippada over 9 years ago
- Status changed from Resolved to In Progress
Reopening because Peter said this was actually due to a bug in the template and the Run button should be disabled.
Updated by Radhika Chippada over 9 years ago
Peter said: as long as a non-empty string is provided for a Collection or File dataclass, we need to check readability. In this particular pipeline, there was a bug in the template where by mistake the output_prefix was configured as dataclass Collection; and hence disabling the Run button is the right behavior. Hence:
- Reverted the previous update. Also, updated to use red font in this case.
- Tested with qr1hi-d1hrv-80zon4obj9ufhvr
- I could not access qr1hi-d1hrv-v3tb1ikn8isbbc5 using my non-admin account.
- However, you can verify using instances in my shared folder if need be (you can be anonymous user): https://workbench.qr1hi.arvadosapi.com/pipeline_instances/qr1hi-d1hrv-z3ko667e07nkzk8
Updated by Radhika Chippada over 9 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:61d399a57fd1e867cc243a0dab0fad73d9689734.
Updated by Radhika Chippada over 9 years ago
- Subject changed from Pipeline Instance input tab should be more verbose to [Workbench] Pipeline Instance input tab should be more verbose