Project

General

Profile

Actions

Bug #5826

closed

[Workbench] Pipeline Instance input tab should be more verbose

Added by Bryan Cosca over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Story points:
-

Description

The user should be able to see which input is not readable, maybe by a red highlight of the input box.

From instance: qr1hi-d1hrv-80zon4obj9ufhvr


Files

butwhichinput.png (58.7 KB) butwhichinput.png Bryan Cosca, 04/27/2015 02:13 PM
Actions #1

Updated by Bryan Cosca over 9 years ago

  • Description updated (diff)
Actions #2

Updated by Bryan Cosca over 9 years ago

This is probably related: The "Input your outputname to allelotype" parameter should be a text box. I've fixed it and didn't receive the error anymore.

However this issue should still stand because I tried to run GATK3 here: qr1hi-d1hrv-v3tb1ikn8isbbc5 on my and it still doesn't show which parameters I need to correct in order to run the pipeline.

Actions #3

Updated by Radhika Chippada over 9 years ago

  • Category set to Workbench
  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version set to 2015-04-29 sprint
Actions #4

Updated by Radhika Chippada over 9 years ago

I think it is failing because of the following component value:

output_prefix = {:required=>true, :dataclass=>"Collection", :title=>"Input your output name to allelotype", :default=>"test"}

I updated the method unreadable_inputs_present? in pipeline_instances_controller to checkout readable only for a pdh or uuid and the issue is now resolved.

However, do we want to do more such as check it is not "output" or "output_prefix" etc?

Actions #5

Updated by Radhika Chippada over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:8464bb48ba769c8bf0984c8b1493ca43fd902891.

Actions #6

Updated by Radhika Chippada over 9 years ago

  • Status changed from Resolved to In Progress

Reopening because Peter said this was actually due to a bug in the template and the Run button should be disabled.

Actions #7

Updated by Radhika Chippada over 9 years ago

Peter said: as long as a non-empty string is provided for a Collection or File dataclass, we need to check readability. In this particular pipeline, there was a bug in the template where by mistake the output_prefix was configured as dataclass Collection; and hence disabling the Run button is the right behavior. Hence:

  • Reverted the previous update. Also, updated to use red font in this case.
Actions #8

Updated by Radhika Chippada over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:61d399a57fd1e867cc243a0dab0fad73d9689734.

Actions #9

Updated by Radhika Chippada over 9 years ago

  • Subject changed from Pipeline Instance input tab should be more verbose to [Workbench] Pipeline Instance input tab should be more verbose
Actions

Also available in: Atom PDF