Bug #5843

[Workbench] Undeleteable sub-project

Added by Abram Connelly over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
04/30/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

I cannot remove sub-project

https://workbench.su92l.arvadosapi.com/projects/su92l-j7d0g-3rbmaji2ifc5gm4

from project

https://workbench.su92l.arvadosapi.com/projects/su92l-j7d0g-gt9w1l3dhb53sod#Subprojects

Hitting the trash can icon does not remove the sub-project.

I've created other projects under this project and have been able to delete them.

The sub-project was created with a curl call:

curl -s -X POST --data 'group={ "name" : "testing2", "group_class" : "project", "owner_uuid" : "su92l-j7d0g-gt9w1l3dhb53sod" }' -A "dax-api" 'https://'$ARVADOS_API_HOST'/arvados/v1/groups' -H 'Accept-Encoding: gzip' -H "Authorization: OAuth2 $ARVADOS_API_TOKEN" -H 'Accept:' 

Where ARVADOS_API_HOST is 'su92l.arvadosapi.com' and the ARVADOS_API_TOKEN is my api token.


Subtasks

Task #5858: Review branch: 5843-subproject-deletion-owner-name-constraintResolvedRadhika Chippada

Associated revisions

Revision ee8d5b17
Added by Radhika Chippada over 6 years ago

closes #5843
Merge branch '5843-subproject-deletion-owner-name-constraint'

History

#1 Updated by Abram Connelly over 6 years ago

I renamed it to '...' and then was able to delete it.

#2 Updated by Radhika Chippada over 6 years ago

I think there was another subproject in Home project with that same name and hence the deletion (moving into Home project) failed. I was able to see this in my env:

#<ArvadosApiClient::ApiErrorResponseException: #<PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "groups_owner_uuid_name_unique"
DETAIL: Key (owner_uuid, name)=(qr1hi-tpzed-ktpvhqu89qoib9f, New subproject) already exists. > [API: 422]>

The question is: in this case, the error message is not shown to the user and the user has no clue of what transpired. The user should be shown this error in this case.

#3 Updated by Radhika Chippada over 6 years ago

  • Subject changed from Undelteable sub-project to Undeleteable sub-project

Collections, groups, and pipeline_templates have the owner_uuid_name_unique constraint.

Currently, when a collection is removed from a project, and another collection with that same name exists in the home project, the collection is renamed by adding the suffix "removed from xxx at ttt". (In fact, this logic is actually no longer used because now we are setting expires_at on collections).

That said, I think we should extend this behavior of renaming when in conflict to groups (subprojects) and templates as well so that user can delete objects with conflicting names.

#4 Updated by Radhika Chippada over 6 years ago

  • Subject changed from Undeleteable sub-project to [Workbench] Undeleteable sub-project
  • Category set to Workbench
  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version changed from Bug Triage to 2015-04-29 sprint

#5 Updated by Radhika Chippada over 6 years ago

  • Target version changed from 2015-04-29 sprint to 2015-05-20 sprint

#6 Updated by Ward Vandewege over 6 years ago

  • Story points set to 0.5

#7 Updated by Brett Smith over 6 years ago

ec359b6 is good to merge. Thanks.

#8 Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:ee8d5b171e2c30ddc3fe829ba4388778e6a78b27.

Also available in: Atom PDF