Bug #5893

[Workbench] Fix unreliable repository browsing

Added by Tom Clegg over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Start date:
05/04/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Sometimes, after getting 401 from arv-git-httpd and asking the credential helper for a password, git exits non-zero instead of retrying the http request with the supplied password. Rare with git v1, common with git v2.

Example from build 1552

  3) Error:
RepositoriesTest#test_browse_using_arv-git-http:
Capybara::ExpectationNotMet: expected to find text "Date: Tue Mar 18 15:55:28 2014 -0400" in "workbench:test Dashboard Projects Home Oh... fiddlesticks. Sorry, I had some trouble handling your request. `git fetch https://localhost:56182/active/foo.git +*:*` pid 13262 exit 128:" 
    test/integration/repositories_browse_test.rb:50:in `block in <class:RepositoriesTest>'
    test/test_helper.rb:274:in `run'

Discussion on #5416 too.


Subtasks

Task #5894: Review 5893-helper-stdinResolvedTom Clegg

Associated revisions

Revision eb330334
Added by Tom Clegg over 6 years ago

Merge branch '5893-helper-stdin' closes #5893

History

#1 Updated by Tom Clegg over 6 years ago

  • Description updated (diff)
  • Category set to Workbench
  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

#2 Updated by Brett Smith over 6 years ago

6fcd070 is good to merge. Thanks.

#3 Updated by Tom Clegg over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:eb3303340c51d13512397c3d83c955af9f516f47.

Also available in: Atom PDF