[API] MAX_SLOTS should be a configuration value (app/models/node.rb)
Make MAX_SLOTS a configurable parameter, and rename it to max_compute_nodes.
Improve comment in application.default.yml based on review feedback.
#3 Updated by Tom Clegg over 6 years ago
Might be worth mentioning in config comment something like: "After this limit is reduced, any existing nodes with slot number >= new limit will not be counted against the new limit. IOW, the new limit won't be strictly enforced until those higher-numbered nodes go down."
I think it would be simpler (and better for testing) to use
Rails.configuration.max_compute_nodes twice instead of copying it to a class variable and using that twice. But LGTM either way. Thanks.