Feature #5926

[API] MAX_SLOTS should be a configuration value (app/models/node.rb)

Added by Ward Vandewege over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
05/06/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #5929: review 5926-parameterize-max-slotsResolvedTom Clegg

Associated revisions

Revision 03580741 (diff)
Added by Ward Vandewege over 6 years ago

Make MAX_SLOTS a configurable parameter, and rename it to max_compute_nodes.

refs #5926

Revision b988327f (diff)
Added by Ward Vandewege over 6 years ago

Improve comment in application.default.yml based on review feedback.

refs #5926

Revision e7e61999
Added by Ward Vandewege over 6 years ago

Merge branch '5926-parameterize-max-slots'

closes #5926

History

#1 Updated by Ward Vandewege over 6 years ago

  • Status changed from New to In Progress
  • Story points set to 0.5

#2 Updated by Ward Vandewege over 6 years ago

  • Assigned To set to Ward Vandewege

#3 Updated by Tom Clegg over 6 years ago

at 0358074

Might be worth mentioning in config comment something like: "After this limit is reduced, any existing nodes with slot number >= new limit will not be counted against the new limit. IOW, the new limit won't be strictly enforced until those higher-numbered nodes go down."

I think it would be simpler (and better for testing) to use Rails.configuration.max_compute_nodes twice instead of copying it to a class variable and using that twice. But LGTM either way. Thanks.

#4 Updated by Ward Vandewege over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:e7e61999bf577b3ba5308c747dda4a0011516aa7.

Also available in: Atom PDF