Actions
Feature #5926
closed
[API] MAX_SLOTS should be a configuration value (app/models/node.rb)
Story points:
0.5
Updated by Ward Vandewege almost 10 years ago
- Status changed from New to In Progress
- Story points set to 0.5
Updated by Tom Clegg almost 10 years ago
at 0358074
Might be worth mentioning in config comment something like: "After this limit is reduced, any existing nodes with slot number >= new limit will not be counted against the new limit. IOW, the new limit won't be strictly enforced until those higher-numbered nodes go down."
I think it would be simpler (and better for testing) to use Rails.configuration.max_compute_nodes twice instead of copying it to a class variable and using that twice. But LGTM either way. Thanks.
Updated by Ward Vandewege almost 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:e7e61999bf577b3ba5308c747dda4a0011516aa7.
Actions