Project

General

Profile

Actions

Idea #6138

closed

[Docker] Docker install uses standalone SSO server

Added by Peter Amstutz almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
05/21/2015
Due date:
Story points:
-

Subtasks 2 (0 open2 closed)

Task #6128: Test Docker installResolvedPeter Amstutz05/21/2015Actions
Task #6133: Review 6090-docker-use-local-ssoResolvedPeter Amstutz05/21/2015Actions
Actions #1

Updated by Peter Amstutz almost 9 years ago

  • Tracker changed from Bug to Idea
Actions #2

Updated by Peter Amstutz almost 9 years ago

  • Project changed from 35 to Arvados
Actions #3

Updated by Peter Amstutz almost 9 years ago

  • Assigned To set to Peter Amstutz
Actions #4

Updated by Nico César almost 9 years ago

reviewing 6090-docker-use-local-sso commit ae3bb0033a24a38489c49ffc26e5a5e8fd93c160

docker/arvdock

  • line 13: hardcoded ARVADOS_DOMAIN=dev.arvados should a parameter
  • line 224: why commenting out #start_vm=true ?

docker/config.yml.example

  • just a curiosity.. is this used as template somewhere in curoverse? or is just for the (external) user to have an example?

docker/workbench/apache2_vhost.in

  • line 26: why is qr1hi hardcoded there? even is a comment couldn't be @ARVADOS_DOMAIN@
Actions #5

Updated by Nico César almost 9 years ago

So I cant really test this in my machine... I have space restrictions and SSD drive is incredible slow. Options here?

Actions #6

Updated by Peter Amstutz almost 9 years ago

Nico Cesar wrote:

reviewing 6090-docker-use-local-sso commit ae3bb0033a24a38489c49ffc26e5a5e8fd93c160

docker/arvdock

  • line 13: hardcoded ARVADOS_DOMAIN=dev.arvados should a parameter

Fixed

  • line 224: why commenting out #start_vm=true ?

Right now it doesn't really work, so it seems better to disable it entirely.

docker/config.yml.example

  • just a curiosity.. is this used as template somewhere in curoverse? or is just for the (external) user to have an example?

It's used by docker/build_tools/build.sh

docker/workbench/apache2_vhost.in

  • line 26: why is qr1hi hardcoded there? even is a comment couldn't be @ARVADOS_DOMAIN@

Removed those comments since they are useless.

Actions #7

Updated by Nico César almost 9 years ago

checked a7d558d6c2db242a6555c7f397cb4d91618aa13c

looks good to me

Actions #8

Updated by Peter Amstutz almost 9 years ago

  • Status changed from New to Resolved

Applied in changeset arvados|commit:e73222a8d0c18b159ae3d8b53b54474650bdda16.

Actions

Also available in: Atom PDF