Bug #6234

[Workbench] Admins should be able to edit their own user records, and view other users' home projects" from title

Added by Ward Vandewege over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
Start date:
06/10/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Admins need to be able to see their own user page to manage their group memberships, etc.

Right now, going to the usual URL for that renders your home project. This was first filed as #3756. We fixed this by making the user page inaccessible, and hiding the Show button for it from the users listing.

It's now clear we need a better solution. In #3756, Tom suggested implementing a "better way to ensure {"move this project to..." → Home → OK} redirects to projects#show with uuid=current_user.uuid instead of users#show." He noted that "solution is a waste of trouble if we decide to switch to the "special undeletable project" implementation for "Home"," but we still haven't done that, so it seems like it's time to implement the longer solution and undo the Show button hiding hack.

After this change (subject to permission, of course):
  • {workbench}/projects/{user_uuid} will show the home project of the given user
  • {workbench}/groups/{user_uuid} will redirect to /projects/{user_uuid} if necessary/convenient (this might not be necessary any more, but it doesn't seem to break anything either, so it's fine to leave it alone).
  • {workbench}/users/{user_uuid} will show the "edit/manage user" page for the given user

Subtasks

Task #6300: Review branch: 6234-user-edit-selfResolvedRadhika Chippada


Related issues

Related to Arvados - Bug #6274: [API] [Workbench] Home project should be a real object (group with group_class="project"), not current_user.New

Related to Arvados - Bug #3573: [Workbench] When showing a shared project, do not include "Home" in breadcrumbs.New

Follows (1 day) Arvados - Bug #3756: [Workbench] As an admin user, clicking 'Show' in the user list on your own user record redirects to a *project* url for the user uuid instead of the *user* url.Resolved01/12/2015

Associated revisions

Revision 665b0fbe
Added by Radhika Chippada about 5 years ago

closes #6234
Merge branch '6234-user-edit-self'

History

#1 Updated by Brett Smith over 5 years ago

  • Description updated (diff)
  • Category set to Workbench
  • Target version changed from Bug Triage to 2015-07-08 sprint

#2 Updated by Brett Smith over 5 years ago

  • Subject changed from [Workbench] User can not edit oneself to [Workbench] User can not edit oneself/Cannot view other users' home project

#3 Updated by Tom Clegg over 5 years ago

This bug will be trivial to fix if we resolve the "owner_uuid can be a user or a project" design oddity: i.e., change from "home project == user" to "each user has exactly one home/default project". See #6274

#4 Updated by Brett Smith over 5 years ago

  • Subject changed from [Workbench] User can not edit oneself/Cannot view other users' home project to [Workbench] User cannot edit oneself/view other user's home project

#5 Updated by Tom Clegg over 5 years ago

  • Story points set to 0.5

#6 Updated by Radhika Chippada over 5 years ago

  • Assigned To set to Radhika Chippada

#7 Updated by Radhika Chippada over 5 years ago

  • Status changed from New to In Progress

#8 Updated by Tom Clegg over 5 years ago

  • Description updated (diff)

#9 Updated by Tom Clegg over 5 years ago

  • Subject changed from [Workbench] User cannot edit oneself/view other user's home project to [Workbench] Admins should be able to edit their own user records, and view other users' home projects

#10 Updated by Radhika Chippada over 5 years ago

  • Subject changed from [Workbench] Admins should be able to edit their own user records, and view other users' home projects to [Workbench] Admins should be able to edit their own user records

#11 Updated by Radhika Chippada over 5 years ago

  • Subject changed from [Workbench] Admins should be able to edit their own user records to [Workbench] Admins should be able to edit their own user records, and view other users' home projects" from title

Reverted previous title update.

#12 Updated by Radhika Chippada over 5 years ago

About updates in branch 6234-user-edit-self:

  • Admin user can now see the "Show" button in /users page and access it
  • Also, updated to allow admin user to see other users' home pages
    • Added Home project link in each row of /users page
    • I added the Home project link for root as well as anonymous users. If we hate it very much, I can add logic to suppress these for specific users.
  • I didn't do anything about second from last bullet point in description "{workbench}/groups/{user_uuid} will redirect to /projects/{user_uuid} if necessary/convenient (this might not be necessary any more, but it doesn't seem to break anything either, so it's fine to leave it alone)." I noticed that /groups/{user_uuid} does not currently work in production. And, since it does not seem necessary, I did not want to invest the time to address this as part of this exercise.

#13 Updated by Peter Amstutz about 5 years ago

Per our discussion, it is extremely confusing when you are viewing the home project of (or any project owned by) another user but the "Home" link in the breadcrumbs bar links to your own home project. This is a preexisting bug, but with the ability to visit other user's home projects it is now even more confusing.

This should be addressed, ideally by having the "Home" link in the breadcrumbs change to point to the topmost owner of the project currently being viewed. There are two other links on the page to your own home project so this does not hurt navigation in any way.

#14 Updated by Peter Amstutz about 5 years ago

Proposed behavior for breadcrumb rendering:

  • When looking at your home project or a subproject of your home project, show "Home" at the root of the breadcrumbs
  • When looking at another user's home project, put the name (or username or email address) at the root of the breadcrumbs
  • When looking at a subproject owned by another user, but we can't read all the way to that user's home project, put the name (or username or email address) at the root of the breadcrumbs with a rendering style to indicate clicking is disabled.
  • When looking at the home project for a group, put the name at the root of the breadcrumbs
  • When looking at a subproject owned by a group, but we can't read all the way to the group home project, put the name at the root of the breadcrumbs with a rendering style to indicate clicking is disabled.

#15 Updated by Tom Clegg about 5 years ago

Moving further discussion of breadcrumbs to #3573.

#16 Updated by Brett Smith about 5 years ago

Peter Amstutz wrote:

Per our discussion, it is extremely confusing when you are viewing the home project of (or any project owned by) another user but the "Home" link in the breadcrumbs bar links to your own home project. This is a preexisting bug, but with the ability to visit other user's home projects it is now even more confusing.

This should be addressed, ideally by having the "Home" link in the breadcrumbs change to point to the topmost owner of the project currently being viewed. There are two other links on the page to your own home project so this does not hurt navigation in any way.

As evidenced by the discussion since, fixing this bug is a story in its own right, and it's not high enough priority to disrupt the current sprint for. Let's deal with #3573 separately, and leave it out of scope for this story. Thanks.

#17 Updated by Radhika Chippada about 5 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:665b0fbe5f57866f9d0183a08e713fe07e8db8de.

Also available in: Atom PDF