Bug #6272

[Keep] keepstored index response should have an EOF marker to enable the client to detect an incomplete response.

Added by Tom Clegg over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
06/11/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

The response size is not known when the headers are written, so (without an EOF marker) it is impossible for the client to detect the difference between "response was truncated at a newline character" and "complete response was received".

Implementation:
  • keepstore writes ".\n" at the end of the index response.
  • data manager throws an error (more or less equivalent to "keep node unreachable"?) if it doesn't see the EOF marker.

Subtasks

Task #6296: Review 6272-index-eofResolvedPeter Amstutz

Associated revisions

Revision 4d0e87db
Added by Tom Clegg over 6 years ago

Merge branch '6272-index-eof' closes #6272

History

#1 Updated by Tom Clegg over 6 years ago

  • Description updated (diff)
  • Project changed from Arvados Private to Arvados
  • Category set to Keep

#2 Updated by Brett Smith over 6 years ago

  • Target version changed from Arvados Future Sprints to 2015-07-08 sprint

#3 Updated by Tom Clegg over 6 years ago

  • Description updated (diff)

#4 Updated by Tom Clegg over 6 years ago

  • Description updated (diff)

#5 Updated by Tom Clegg over 6 years ago

  • Assigned To set to Tom Clegg

#6 Updated by Peter Amstutz over 6 years ago

Just one comment, maybe terminate with just an extra newline (similar to the way HTTP headers are terminated) instead of "."?

#7 Updated by Tom Clegg over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:4d0e87db2bef1f30634d28338e89227b985e6485.

Also available in: Atom PDF