Project

General

Profile

Actions

Bug #6304

closed

[API] Fix config file race condition and improve test cases for DNS update hooks

Added by Tom Clegg about 7 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
05/23/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Node.dns_server_update() in source:services/api/app/models/node.rb is currently vulnerable to the following race (fixable by using a tempfile library):
  • Request handler A writes hostname.conf.tmp.
  • Request handler B opens hostname.conf.tmp for writing.
  • Request handler A issues the move command.

Catch only the expected exceptions on the various write and update operations (IOError and SystemCallError?), not unexpected ones.


Subtasks 3 (0 open3 closed)

Task #6246: Add test case for dns configsClosed05/23/2015

Actions
Task #6245: Improve race and exception handling in dns updatesClosed05/23/2015

Actions
Task #11382: Review 6304-dns-update-fixResolvedLucas Di Pentima05/23/2015

Actions
Actions

Also available in: Atom PDF