Project

General

Profile

Actions

Bug #6318

open

[SDKs] Go SDK locator regexp (and its tests) should agree with the documented format

Added by Tom Clegg almost 9 years ago. Updated 17 days ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
SDKs
Target version:
Story points:
0.5
Release:
Release relationship:
Auto

Description

Incorrect test cases in source:sdk/go/manifest/manifest_test.go that disagree with the documented Keep locator format:
  • "A2345678901234abcdefababdeffdfdf+12345" is listed valid, but is invalid. The hash part is not allowed to contain uppercase letters.
  • "12345678901234567890123456789012+12345+A" is listed invalid, but is valid. Hint content is allowed to be empty.

The regexp in manifest.go should match the one given on the wiki page, and test cases should be updated accordingly.

Asides:
  • Sharing a single set of test cases among all SDKs' test suites might help prevent this bug from reappearing.
  • In case that regexp ever changes, we could designate one SDK as the official regexp, and link the wiki page to the appropriate source file instead of trying to keep them synchronized manually.
Actions #1

Updated by Tom Clegg almost 6 years ago

Actions #2

Updated by Ward Vandewege over 2 years ago

  • Target version deleted (Arvados Future Sprints)
Actions #3

Updated by Peter Amstutz about 1 year ago

  • Release set to 60
Actions #4

Updated by Peter Amstutz 17 days ago

  • Target version set to Future
Actions

Also available in: Atom PDF