Bug #6604

[Workbench] Notification menu should not prompt the user to upload an SSH key when a Web shell is available

Added by Brett Smith over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Start date:
07/16/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Now Web shells are available, users do not need to upload an SSH key to fully use Arvados. Dax should not prompt the user to add one in this case. It is more likely to confuse users who don't know what is than be helpful.


Subtasks

Task #6650: Review Branch 6604-notification-menu-no-promptResolvedRadhika Chippada

Associated revisions

Revision 702ce6c3
Added by Manoj Malipeddu over 6 years ago

closes #6604
Merge branch '6604-notification-menu-no-prompt'

History

#1 Updated by Joshua Randall over 6 years ago

From a user point of view, I probably wouldn't mind if I got the notification from Dax once that suggested I might want to upload an ssh key, but there should be a way to say "no thanks" and dismiss that message.

#2 Updated by Brett Smith over 6 years ago

  • Target version changed from 2015-08-19 sprint to 2015-08-05 sprint

#3 Updated by Brett Smith over 6 years ago

Joshua Randall wrote:

From a user point of view, I probably wouldn't mind if I got the notification from Dax once that suggested I might want to upload an ssh key, but there should be a way to say "no thanks" and dismiss that message.

Thanks for the feedback, Josh. There's a very recent development that's relevant here: we just merged support so that it's possible to open SSH sessions to Arvados VMs from your Web browser, authenticated by your Arvados API token. Now that that's available, we're probably going to be deemphasizing general SSH access across the board. It will remain available, of course, but we're going to advertise it to users less. It'll be more for people who already use SSH clients and keys, and know they want it.

I know this doesn't exactly matched what we discussed, but it wasn't until I sat down to write this ticket that I remembered the two issues are related.

#4 Updated by Radhika Chippada over 6 years ago

  • Subject changed from [Workbench] Dax does not prompt the user to upload an SSH key when a Web shell is available to [Workbench] Notification menu should not prompt the user to upload an SSH key when a Web shell is available
  • Assigned To set to Manoj Malipeddu
  • Target version changed from 2015-08-05 sprint to 2015-07-22 sprint

#5 Updated by Manoj Malipeddu over 6 years ago

  • Status changed from New to In Progress

#6 Updated by Manoj Malipeddu over 6 years ago

In 25e646a708d1d91aebcf8db80b8ae1fafa044034:

Removed notification for SSH key if web shell is configured.

Added "no SSH public key notification when shell_in_a_box_url is configured" test to application_layout_test.

#7 Updated by Radhika Chippada over 6 years ago

LGTM

#8 Updated by Manoj Malipeddu over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:702ce6c3da9a1b09a2ed546fd3da775d21bd703b.

Also available in: Atom PDF