Arvados

In 4999699d7614f214eb8718b85c5c30e9fb382c23:

Added tests for the system menu and the pages in the dropdown menu.

In 61d432f332dd9314f8c4cd57c2393e80e8ecef59:

System menu test now skips repositories and test has been moved to application_layout_test.

I played with Tom's suggestion "moving self.owner_uuid ||= current_user.uuid into a before_validation method" and this does not solve the problem.

• need to make the API update
• update workbench to show the same popup as in user/repositories page. Alternatively, we can hide the New button admin#repositories page. I think this might actually be the right option, because what good is it to create all these repositories as <admin_user>/repo_name?
• "arv repository create" should work provided name is provided as in Tom's example in the description.

Reopening to address the last comment added by Tom in note #12.

So, what needs to be done: When accessed from admin settings menu,

• /repositories page should not offer the "Add a new repository" button

• /authorized_keys page also does not need to offer the "Add a new authorized key" button.

In 84d14d659b8c31c266a3b08e688171f90fe46cad:

Add a new repository and add a new authorized key buttons no longer appear in the admin pages and tests have been updated.

Review comments:

• Please add an else block for "if add_button_text" in the test

      if add_button_text
        assert_selector 'button', text: "Add a new #{add_button_text}" 
        find('button', text: "Add a new #{add_button_text}").click
      else
        assert_no_selector 'button', text: "Add a new" 
      end

• Can you please use "assert_text" instead of "page.has_text?" in the last statement of the test

Thanks.

In 3bfb9c5cbf5dd56b84fd17f9e1dcdd6a219fe5fe:

Added else statement and changed assertion to use assert_text in "test system menu #{page_name} link".