Project

General

Profile

Actions

Bug #6681

closed

[SDK] arv-put fails with invalid seek when input is piped in

Added by Peter Amstutz almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
SDKs
Target version:
Story points:
0.5

Subtasks 2 (0 open2 closed)

Task #6710: Review 6681-arv-put-pipeResolvedNico César07/23/2015Actions
Task #6709: FixResolvedPeter Amstutz07/23/2015Actions

Related issues

Related to Arvados - Task #7570: [SDKs] a-r-p-i should write to stdout directly, rather than opening /dev/stdoutNewActions
Actions #1

Updated by Peter Amstutz almost 9 years ago

  • Story points set to 0.5
Actions #2

Updated by Brett Smith almost 9 years ago

  • Project changed from 35 to Arvados
  • Category set to SDKs
  • Target version changed from Bug Triage to 2015-08-05 sprint
Actions #3

Updated by Peter Amstutz almost 9 years ago

  • Assigned To set to Peter Amstutz
Actions #4

Updated by Nico César over 8 years ago

reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391

there is a easy way to mess this around.

having a stdin file on the working directory and doing

arv-put stdin -

the resulting collection will have only the standard input.

What do we want to do with this edge case:

- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore it
Actions #5

Updated by Nico César over 8 years ago

also sdk/cli/test/test_arv-put.rb should be updated ... writing a simple "hello" from stdin and then checking the md5 of the resulting stdin file

Actions #6

Updated by Peter Amstutz over 8 years ago

Nico Cesar wrote:

reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391

there is a easy way to mess this around.

having a stdin file on the working directory and doing

arv-put stdin -

the resulting collection will have only the standard input.

What do we want to do with this edge case:

- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore it

Changed to disallow additional files on the command line when getting data from stdin.

also sdk/cli/test/test_arv-put.rb should be updated ... writing a simple "hello" from stdin and then checking the md5 of the resulting stdin file

Those tests are skipped (unfortunately) and I don't think fixing them is part of the scope of this ticket.

Actions #7

Updated by Peter Amstutz over 8 years ago

Peter Amstutz wrote:

Nico Cesar wrote:

reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391

there is a easy way to mess this around.

having a stdin file on the working directory and doing

arv-put stdin -

the resulting collection will have only the standard input.

What do we want to do with this edge case:

- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore it

Changed to disallow additional files on the command line when getting data from stdin.

From office conversation: will back out this change. If a user uploads a file called "stdin" while also piping from stdin, the files will be concatenated.

Actions #8

Updated by Peter Amstutz over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:ff24bb94fdfc9dad61821aef56898e2c196c0aea.

Actions

Also available in: Atom PDF