Bug #6681
closed[SDK] arv-put fails with invalid seek when input is piped in
Updated by Brett Smith over 9 years ago
- Project changed from 35 to Arvados
- Category set to SDKs
- Target version changed from Bug Triage to 2015-08-05 sprint
Updated by Nico César over 9 years ago
reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391
there is a easy way to mess this around.
having a stdin file on the working directory and doing
arv-put stdin -
the resulting collection will have only the standard input.
What do we want to do with this edge case:
- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore it
Updated by Nico César over 9 years ago
also sdk/cli/test/test_arv-put.rb should be updated ... writing a simple "hello" from stdin and then checking the md5 of the resulting stdin file
Updated by Peter Amstutz over 9 years ago
Nico Cesar wrote:
reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391
there is a easy way to mess this around.
having a stdin file on the working directory and doing
arv-put stdin -
the resulting collection will have only the standard input.
What do we want to do with this edge case:
- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore it
Changed to disallow additional files on the command line when getting data from stdin.
also sdk/cli/test/test_arv-put.rb should be updated ... writing a simple "hello" from stdin and then checking the md5 of the resulting stdin file
Those tests are skipped (unfortunately) and I don't think fixing them is part of the scope of this ticket.
Updated by Peter Amstutz over 9 years ago
Peter Amstutz wrote:
Nico Cesar wrote:
reviewing 229773c2aa3ddc798ae4eb1eff62f8f77db85391
there is a easy way to mess this around.
having a stdin file on the working directory and doing
arv-put stdin -
the resulting collection will have only the standard input.
What do we want to do with this edge case:
- concatenate both
- do a collision detection (i.e. create stdin2 for the second input)
- ignore itChanged to disallow additional files on the command line when getting data from stdin.
From office conversation: will back out this change. If a user uploads a file called "stdin" while also piping from stdin, the files will be concatenated.
Updated by Peter Amstutz over 9 years ago
- Status changed from New to Resolved
- % Done changed from 50 to 100
Applied in changeset arvados|commit:ff24bb94fdfc9dad61821aef56898e2c196c0aea.