Bug #6846

[Workbench] Top nav login link loses user's place in Workbench

Added by Nancy Ouyang over 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
Workbench
Target version:
Start date:
11/09/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

If I'm not logged in and open a link to a project I can access, I get access denied. However, after I log-in, I get redirected to the homepage, instead of back to the project, which is slightly annoying.


Subtasks

Task #7739: Review 6846-workbench-top-nav-login-returns-wipResolvedRadhika Chippada

Associated revisions

Revision 8d9db886
Added by Brett Smith about 4 years ago

Merge branch '6846-workbench-top-nav-login-returns-wip'

Closes #6846, #7739.

Revision 99ce6a94 (diff)
Added by Brett Smith almost 4 years ago

6846: Streamline Workbench 404 page.

  • Prompt the user to log in with a prominent button.
  • Make the page text less verbose.
  • DRY up the code in the _report_error partial.

Refs #6846.

History

#1 Updated by Radhika Chippada over 4 years ago

Nancy, please confirm:

Clicking the log in link within in the body of the Page not found error page (I notice you are not logged in. If you're looking for a private page, you'll need to log in first), does take me to the page that brought me to the error page.

However, clicking on the Log in link in the top navigation bar takes me to home page.

#2 Updated by Nancy Ouyang over 4 years ago

If I got to
https://workbench.su92l.arvadosapi.com/projects/su92l-j7d0g-swtofxa2rct8495
I get

Not Found
The group with UUID su92l-j7d0g-swtofxa2rct8495 was not found.

Then I click "log in" on the top nav bar, and it goes to the homepage.

The log-in link inside the page itself totally works --

(I notice you are not logged in. If you're looking for a private page, you'll need to log in first.)

but I didn't notice it until you pointed it out.

So a quickfix would be to make that link bigger or look more like a button?

#3 Updated by Radhika Chippada over 4 years ago

Thanks for clarifying Nancy.

I am also wondering if it would be feasible to use the same login link generation logic (as in the text "If you're looking for a private page, you'll need to log in first") for the Login link in the top navigation bar as well. So, it would either point to the page under consideration in a situation like you encountered or points to dashboard when no such scenario exists.

#4 Updated by Brett Smith over 4 years ago

Radhika Chippada wrote:

I am also wondering if it would be feasible to use the same login link generation logic (as in the text "If you're looking for a private page, you'll need to log in first") for the Login link in the top navigation bar as well.

I agree, we should at least do this. No login link or button should forget the user's place in Workbench.

#5 Updated by Brett Smith over 4 years ago

  • Subject changed from User is redirected to homepage of workbench instead of project after logging in to [Workbench] Top nav login link loses user's place in Workbench
  • Category set to Workbench
  • Target version changed from Bug Triage to Arvados Future Sprints
  • Story points set to 0.5

#6 Updated by Brett Smith about 4 years ago

  • Status changed from New to In Progress
  • Assigned To set to Brett Smith

#7 Updated by Brett Smith about 4 years ago

  • Target version changed from Arvados Future Sprints to 2015-11-11 sprint

#8 Updated by Brett Smith about 4 years ago

  • Target version changed from 2015-11-11 sprint to 2015-12-02 sprint

#9 Updated by Radhika Chippada about 4 years ago

Clicking on the login link in top nav or the top nav hover dropdown links is resulting in the following error: {"errors":["#<NoMethodError: undefined method `[]' for nil:NilClass>"],"error_token":"1447346070+a90d2159"}

#10 Updated by Brett Smith about 4 years ago

Radhika Chippada wrote:

Clicking on the login link in top nav or the top nav hover dropdown links is resulting in the following error: {"errors":["#<NoMethodError: undefined method `[]' for nil:NilClass>"],"error_token":"1447346070+a90d2159"}

Thanks for catching that. Ready for another look at 702ff97.

#11 Updated by Radhika Chippada about 4 years ago

Now the login actions from topnav are working and the return URL is also preserved.

LGTM

#12 Updated by Brett Smith about 4 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:8d9db88641ada8ecd5400fe4affd9b90647c5d3a.

Also available in: Atom PDF