Bug #6924

Google survey participation link should work for newly created surveys, too

Added by Tom Clegg about 6 years ago. Updated about 6 years ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Third party integration
Target version:
-
Start date:
08/06/2015
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

See e70c808ab4518cf68ae56f702ae64f5232bbc0ba

My theory:

# Google changed the field IDs on existing forms/results. Old
# field IDs were small multiples of 10, and were changed from N to
# 1000000+N; new ones are big numbers and should be used verbatim.

Current code always adds 1000000. According to Nancy's experiments, this means in order to conduct a survey with a newly created Google form, you have to enter "2014123456" when the real form field ID is "2015123456".


Subtasks

Task #6925: Review 6924-survey-field-idNewWard Vandewege

Associated revisions

Revision 97810dd6
Added by Tom Clegg about 6 years ago

Merge branch '6924-survey-field-id' refs #6924

History

#1 Updated by Tom Clegg about 6 years ago

6924-survey-field-id @ 9348c84

Incidental improvements:
  • Detect form_url has no "?", and add one before query string if needed
  • Cherry-pick tests from #2930
  • Add unit tests for field-id-munging, and functional test for correct "participate" redirect url

#2 Updated by Tom Clegg about 6 years ago

  • Status changed from New to In Progress

#3 Updated by Tom Clegg about 6 years ago

  • Description updated (diff)

#4 Updated by Ward Vandewege about 6 years ago

Ran tests with

RAILS_ENV=test bundle exec rake test:functionals TEST=test/functional/google_surveys_controller_test.rb

(thanks for the hint Tom). LGTM.

Also available in: Atom PDF