Project

General

Profile

Actions

Bug #6967

closed

[API] [Workbench] application.default.yml should not call git, at least in production

Added by Brett Smith about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
0.5

Description

Both API server and Workbench call git a couple of times in application.default.yml:

  source_version: "<%= `git log -n 1 --format=%h`.strip %>" 
  local_modified: "<%= '-modified' if `git status -s` != '' %>" 

These calls don't work on deployments from our packages. Worse, source_version causes a crash when starting the server if git is not installed or not in the user's $PATH. At the very least, the production section should get all these without calling git.


Subtasks 2 (0 open2 closed)

Task #7480: Review 6967-yaml-formatResolvedPeter Amstutz09/23/2015Actions
Task #7375: Review 6967-application-yml-without-git-wipResolvedBrett Smith09/23/2015Actions
Actions

Also available in: Atom PDF