Project

General

Profile

Actions
Copy link

Feature #7330

closed

[SSO] Convert arvados-sso-server-upgrade.sh to fpm after-install/before-remove scripts

Added by Brett Smith over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Ward Vandewege
Category:
SSO
Target version:
2015-09-30 sprint
Story points:
2.0

Description

The after-install script should, in the usual case, perform all the same actions that arvados-sso-server-upgrade.sh currently performs. However, there are some expected implementation differences:

  • Be prepared to be called with dpkg's calling arguments or rpm's calling arguments. If some actions don't make sense in some calling scenarios, make sure they're skipped.
  • Instead of introspecting the system to determine whether we're on Debian or Red Hat, use the calling arguments so we get that information directly from the packaging system, which should be more reliable.
  • Instead of copying /etc/arvados/sso/*.yml to /var/www/arvados-sso/current/config, we should make symlinks in /var to files in /etc, so the copies don't get out of sync with the canonical versions. If there's a way to do this directly with fpm, feel free to do that, since it will probably be more reliable. But if nothing else, you can make the symlinks in the after-install script, and add a before-remove script to remove them when the last version of the package is being removed (so they don't interfere with removing all of /var/www/arvados-sso).
  • Update our install guide to remove references to running arvados-sso-server-upgrade.sh.

Subtasks 1 (0 open — 1 closed)

Task #7348: ReviewResolvedWard Vandewege09/14/2015Actions
Actions
Copy link
 #1

Updated by Brett Smith over 8 years ago

  • Subject changed from [SSO] Convert arvados-sso-server-upgrade.sh to a postinst script in Debian packages to [SSO] Convert arvados-sso-server-upgrade.sh to an fpm after-install script
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Brett Smith over 8 years ago

  • Subject changed from [SSO] Convert arvados-sso-server-upgrade.sh to an fpm after-install script to [SSO] Convert arvados-sso-server-upgrade.sh to fpm after-install/before-remove scripts
  • Description updated (diff)
Actions
Copy link
 #3

Updated by Brett Smith over 8 years ago

  • Description updated (diff)

We are kicking downgrades out of this ticket. We'll deal with them separately, later.

Actions
Copy link
 #4

Updated by Brett Smith over 8 years ago

  • Story points set to 2.0
Actions
Copy link
 #5

Updated by Brett Smith over 8 years ago

  • Target version changed from Arvados Future Sprints to 2015-09-30 sprint
Actions
Copy link
 #6

Updated by Brett Smith over 8 years ago

  • Assigned To set to Nico César
Actions
Copy link
 #7

Updated by Ward Vandewege over 8 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to In Progress
Actions
Copy link
 #8

Updated by Ward Vandewege over 8 years ago

  • Assigned To changed from Nico César to Ward Vandewege
Actions
Copy link
 #9

Updated by Ward Vandewege over 8 years ago

Branches to review:

arvados repository: 7330-improved-sso-package
arvados-dev repository: 7330-postinst-for-sso-server

Notes for review of 7330-postinst-for-sso-server:

Build package for one target:

WORKSPACE=path/to/sso-provider ./run-build-packages-one-target.sh --target ubuntu1204 --command run-build-packages-sso.sh

I've also created a 'run-test-packages-sso.sh' script, which runs a few basic tests. It makes sure the generated package can actually be installed and uninstalled without errors (and without leaving stray files behind):

WORKSPACE=path/to/sso-provider ./run-build-packages-one-target.sh --target ubuntu1204 --command run-test-packages-sso.sh

All targets:

WORKSPACE=path/to/sso-provider ./run-build-packages-all-targets.sh --command run-build-packages-sso.sh

Test all targets:

WORKSPACE=path/to/sso-provider ./run-build-packages-all-targets.sh --command run-test-packages-sso.sh

Notes for review of 7330-improved-sso-package:

This is a documentation branch. It updates the SSO server installation instructions. I encourage you to pick one of our supported distributions and do a manual installation according to the instructions (for example, in a Docker container).

Actions
Copy link
 #10

Updated by Nico César over 8 years ago

I reviewed both branches.

arvados c6d10ad822ac94453d74371af0bf57072c43f018
arvados-dev 1c82c1f875ca2681ff36e804fde8f6beb8f36c77

I created my own deb for the installation and followed all the instructions from the documentation.

pull 'arvados' up to d084c7b404fa0cb597fbba4dcb007c087da49ba5 there are minor changes

LGTM!

Actions
Copy link
 #11

Updated by Ward Vandewege over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:4e8c321b344d8ec23de7ee7c68b2553d87defb67.

Actions
Copy link

Also available in: Atom PDF