Bug #7600

[Crunch] Unhelpful translation of script parameter outside script_parameters

Added by Brett Smith over 3 years ago. Updated over 3 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Crunch
Target version:
Start date:
10/16/2015
Due date:
% Done:

0%

Estimated time:
Story points:
1.0

Description

Problem

A user wrote a pipeline template that used run-command's task.env directive. They accidentally defined task.env outside script_parameters, in the top-level component definition.

The resulting job failed because of the missing environment. Weirder, task.env did appear as a script_parameter in that job, but as a string like "{ \"KEY\": \"value\" }". It's hard to imagine how this behavior helps, and it made the issue more confusing to debug because task.env at least appeared to be in the script_parameters.

Crunch should either add the parameter without stringifying it, or not add the parameter at all.

Fix

We believe this is backward compatibility code for older Arvados pipelines.

  • Take out this translation code.
  • Before creating any jobs, a-r-p-i should check the entire pipeline for unrecognized component fields like this, and report them all as fatal errors to the user, then abort.
  • Add test(s) to the CLI test suite for a-r-p-i.

History

#1 Updated by Brett Smith over 3 years ago

  • Description updated (diff)
  • Story points set to 1.0

#2 Updated by Brett Smith over 3 years ago

  • Target version set to Arvados Future Sprints

Also available in: Atom PDF