Story #7668

[Crunch] Get node hardware information from properties, not info

Added by Brett Smith almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
Crunch
Target version:
Start date:
10/28/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

History:

  • Node hardware information used to be in the info field.
  • Node info is only visible to admins. In #3605, we moved this information to properties, so non-admins could see it.
  • We neglected to updated crunch-dispatch to keep up with this change.

Wherever crunch-dispatch looks for node hardware info (under the keys total_ram_mb, total_scratch_mb, and total_cpu_cores), make sure it's looking in the properties field, rather than info.


Subtasks

Task #7672: Review 7668-crunch-node-properties-wipResolvedBrett Smith

Associated revisions

Revision 8dea5d62
Added by Brett Smith almost 6 years ago

Merge branch '7668-crunch-node-properties-wip'

Closes #7668, #7672.

History

#1 Updated by Brett Smith almost 6 years ago

  • Story points set to 0.5

#2 Updated by Brett Smith almost 6 years ago

  • Description updated (diff)

#3 Updated by Brett Smith almost 6 years ago

  • Description updated (diff)
  • Category set to Crunch
  • Assigned To set to Radhika Chippada

Confirmed that crunch-job does not look at this information.

#4 Updated by Brett Smith almost 6 years ago

  • Status changed from New to In Progress
  • Assigned To changed from Radhika Chippada to Brett Smith

7668-crunch-node-properties-wip is up for review. It is a less-than-one-line change, but please double-check my work that this will bring all of Crunch in line with the current way node information is stored.

#5 Updated by Tom Clegg almost 6 years ago

f76d7ea LGTM.

I've also pushed cf56615 to 7668-crunch-node-properties-wip, moving stats to properties in source:services/api/test/fixtures/nodes.yml.

If that looks right to you too, please merge.

#6 Updated by Brett Smith almost 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:8dea5d629b93c1a8201cd347be19fc6f48239622.

Also available in: Atom PDF