Arvados

7697-socket-retry @ 54fc73b

54fc73b just has one small bug that should get fixed before merge: except httplib.BadStatusLine, httplib.HTTPException: should just say except httplib.HTTPException:. What you wrote will catch httplib.BadStatusLine exceptions and bind any exception caught to httplib.HTTPException. BadStatusLine inherits from HTTPException, so we can just catch that.

Beyond that, I just have small readability suggestions, none of which are necessary for merge:

• The import Queue added to test_api.py seems unused.
• Two blank lines before the RetryREST definition would be nicely PEP 8-compliant.
• self.api._http.orig_http_request.side_effect = lambda x, *a, **k: self.request_success I think can just be self.api._http.orig_http_request.return_value = self.request_success. side_effect takes precedence over return_value, so test methods that override that will still work as intended.
• You can DRY up _test_connection_close by changing self.api._http.connections = {str(i): mock_conns[i] for i in range(2)} to self.api._http.connections = {str(i): c for i, c in enumerate(mock_conns)}.

Thanks.