Bug #7743

[Workbench] Hide file preview buttons when preview isn't possible with current keep-web config

Added by Tom Clegg almost 4 years ago. Updated over 3 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Workbench
Target version:
Start date:
05/21/2015
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

See CollectionsController#keep_web_url.

From #5824 note 25:

  • If keep_web_download_url is set, disposition=attachment links (i.e., downloads) are routed to the given URL (typically https://download.uuid_prefix.arvadosapi.com/c=%{uuid_or_pdh}). This is expected to match keep-web's -attachment-only-host argument.
  • If keep_web_download_url is set and keep_web_url is not set, preview is disabled and all preview/download links are routed to keep_web_download_url.
  • If both are set, but keep_web_url isn't a wildcard (one-vhost-per-collection) form and trust_all_content isn't true, showing inline content from a non-public non-shareable-link collection will result in a download instead of preview.
  • If keep_web_download_url is not set, and keep_web_url isn't a wildcard form, and trust_all_content isn't set, showing inline content from a non-public non-shareable-link collection will produce an error: with that configuration, we can't authenticate safely without creating XSS problems.

Don't render file preview buttons in cases 2-4.


Subtasks

Task #8126: ReviewNewTom Clegg


Related issues

Related to Arvados - Story #5824: [Workbench] [Keep] collection browse/download serverResolved05/21/2015

History

#1 Updated by Tom Clegg almost 4 years ago

  • Subject changed from Hide preview button when preview isn't possible to [Workbench] Hide file preview buttons when preview isn't possible with current keep-web config
  • Description updated (diff)
  • Category set to Workbench
  • Assigned To deleted (Tom Clegg)
  • Parent task deleted (#5824)

#2 Updated by Tom Clegg almost 4 years ago

  • Tracker changed from Task to Bug
  • Target version changed from 2015-11-11 sprint to Arvados Future Sprints

#3 Updated by Brett Smith almost 4 years ago

  • Target version deleted (Arvados Future Sprints)

#4 Updated by Brett Smith almost 4 years ago

  • Target version set to Arvados Future Sprints

#5 Updated by Brett Smith almost 4 years ago

  • Description updated (diff)

#6 Updated by Brett Smith almost 4 years ago

  • Story points set to 1.0

#7 Updated by Brett Smith over 3 years ago

  • Assigned To set to Radhika Chippada
  • Target version changed from Arvados Future Sprints to 2016-01-20 Sprint

#8 Updated by Brett Smith over 3 years ago

  • Target version changed from 2016-01-20 Sprint to Arvados Future Sprints

#9 Updated by Brett Smith over 3 years ago

  • Assigned To deleted (Radhika Chippada)

#10 Updated by Brett Smith over 3 years ago

  • Description updated (diff)

Also available in: Atom PDF