Task #7758

Story #7696: [SDKs] PySDK KeepClient works with all service types, applying rules for the proxy type

Review 7696-pysdk-all-keep-service-types-wip

Added by Brett Smith over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
-
Target version:
Start date:
11/11/2015
Due date:
% Done:

100%

Estimated time:

Associated revisions

Revision be2d7e55
Added by Brett Smith over 4 years ago

Merge branch '7696-pysdk-all-keep-service-types-wip'

Closes #7696, #7758.

History

#1 Updated by Brett Smith over 4 years ago

7696-pysdk-all-keep-service-types-wip is up for review. You will probably want to review this by reading each commit individually (git log -p). Adding the test to ensure writing threads == 1 regularly tickled a race condition, which I think has affected other Keep writing tests in the past. I finally tracked that down and fixed it, and ended up making several improvements to ThreadLimiter in the process. So there are three main commits:

  • One to use Keep services of all types.
  • One to test thread limiting, and fix the associated race condition.
  • One to make various ThreadLimiter improvements that happened along the way of working on the previous commit.

I think they'll be easier to understand if you read each in isolation.

#2 Updated by Radhika Chippada over 4 years ago

  • Assigned To set to Radhika Chippada

#3 Updated by Tom Clegg over 4 years ago

  • Assigned To changed from Radhika Chippada to Tom Clegg

#4 Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress

#5 Updated by Tom Clegg over 4 years ago

  • Assigned To changed from Tom Clegg to Brett Smith

#6 Updated by Brett Smith over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
  • Remaining (hours) set to 0.0

Applied in changeset arvados|commit:be2d7e55af1036699282d06f629805b6508b6ceb.

Also available in: Atom PDF