Arvados

I'm reviewing def93d4e3c614709602cb7052acb0349b2e11e46 on puppet repo

I notice "-s3-access-key-file=/etc/keepstore/amazon_s3_access.key and -s3-secret-key-file=/etc/keepstore/amazon_s3_secret.key" as new parameter.

it comes to my mind why 2 files? is harder to administer and the access/secret bundle goes hand-by-hand. You can't get a new secret for a already existing access. So it will make more sense to me to have either:

1. all config in one file including credentials
2. if the credentials are a sensitive information I prefer 1 key with the access and secret i.e.

-s3-auth-file=/etc/keepstore/amazon_s3_auth.key

Nico Cesar wrote:

I'm reviewing def93d4e3c614709602cb7052acb0349b2e11e46 on puppet repo

forgot to make the note in this ticket. This shouldn't stop the merge, but it's nice to have all the config in one place