Arvados

8014-rails-postinst-scripts-wip is up for review. It does both this and #8059, and it does them both by DRYing up all the Rails package infrastructure into a single stack. Now run-library.sh has a handle_rails_package function, and it's used to build the API server, Workbench, and SSO server, with just small hooks to account for the differences between them.

First the branch makes several small bugfixes and cleanups to the SSO package postinst to make it ready to handle the other packages. This is a long series of small commits explaining each change.

Then there's the big unifying commit to bring all the Rails package-building infrastructure together. If you run git show -M on that last commit, you can see the changes in the postinst script that mostly just serve to unify it for all packages, compared to the last version of the SSO postinst script.

handle_rails_package builds postinst/prerm/postrm scripts for all these packages on the fly. See jenkins/rails-package-scripts/README.md for details.

Also: for all three packages, I was able to install the modified package, fill in the necessary .yml files, and reconfigure the package and see it finish all the postinst steps. So there's been at least that much testing.

I compiled the branch and copy the arvados-api-server to c97qk ... it seems like a successful install .. it did even a database schema change:

c97qk:~# dpkg -i arvados-api-server_0.1.20160104193447.3344f5b-3_amd64.deb
(Reading database ... 69923 files and directories currently installed.)
Preparing to unpack arvados-api-server_0.1.20160104193447.3344f5b-3_amd64.deb ...
Unpacking arvados-api-server (0.1.20160104193447.3344f5b-3) over (0.1.20151223192841.378e6e0-1) ...
Setting up arvados-api-server (0.1.20160104193447.3344f5b-3) ...

Assumption: nginx is configured to serve Rails from
            /var/www/arvados-api/current
Assumption: nginx and passenger run as www-data:www-data

Creating symlinks to configuration in /etc/arvados/api ...... done.
Running bundle install... done.
Ensuring directory and file permissions ...... done.                                                                                                                        
Running db:migrate...==  AddExitCodeToContainers: migrating ========================================                                                                        
-- add_column(:containers, :exit_code, :integer)                                                                                                                            
   -> 0.0009s                                                                                                                                                               
==  AddExitCodeToContainers: migrated (0.0010s) ===============================                                                                                             

 done.
Checking application.yml for completeness...AppVersion (discovered)          378e6e0-1 
action_controller.perform_caching true
admin_notifier_email_from        support@curoverse.com
arvados_docsite                  https://doc.arvados.org
(..)
sso_app_id                       c97qk.arvadosapi.com
sso_app_secret                   *********
sso_insecure                     false
sso_provider_url                 https://auth.curoverse.com
user_notifier_email_from         support@curoverse.com
user_profile_notification_address false
uuid_prefix                      c97qk
websocket_address                wss://ws.c97qk.arvadosapi.com/websocket
workbench_address                https://workbench.c97qk.arvadosapi.com
 done.
Precompiling assets... done.
 * Restarting nginx nginx                                                                                                                                            [ OK ] 
c97qk:~# echo $?
0

I did a mistake and added some comments in the review ticket see https://dev.arvados.org/issues/8036#note-12

but this LGTM. lets merge

_install_rails_reconfigure.liquid is missing

Peter Amstutz wrote:

_install_rails_reconfigure.liquid is missing

Sorry about that. Fixed in 78ae7f1.

Brett Smith wrote:

Peter Amstutz wrote:

_install_rails_reconfigure.liquid is missing

Sorry about that. Fixed in 78ae7f1.

With that fix, looks good to me.

Everything built and deployed successfully last night, so I'm going to call this resolved. I imagine we'll find bugs in the new stuff but those can be new issues.