Bug #8113

"Download the full log" in log tab should show the log in the browser, not download

Added by Bryan Cosca over 1 year ago. Updated 4 months ago.

Status:ResolvedStart date:01/05/2016
Priority:NormalDue date:
Assignee:Tom Clegg% Done:

0%

Category:Workbench
Target version:-
Story points-
Velocity based estimate-

Description

Previous behavior:

"Download the full log" button caused the full job log to appear in the browser window.

Current behavior:

"Download the full log" button results in a file download, which (when it's finished) the user can then open with an external application.
  • This means more waiting and clicking before the text appears, and clutters the download directory with log files the user never wanted to save locally.
  • Generally, these downloaded logs are not formatted that a normal text editor can view it nicely.

Desired behavior:

"View the full log" button displays the log text in the browser window.

(If there is also a "Download" link too, that's harmless -- but "view" is more important, and the browser has a "save as" feature, and in that sense a "view" button covers both "view" and "download" functionality.)

History

#1 Updated by Brett Smith over 1 year ago

  • Status changed from New to Resolved

This was a keep-web deployment issue that has been fixed on the ops end.

#2 Updated by Bryan Cosca 10 months ago

  • Description updated (diff)
  • Status changed from Resolved to New

#3 Updated by Tom Clegg 10 months ago

  • Subject changed from "Download the full log" in log tab actually downloads the log to "Download the full log" in log tab should show the log in the browser, not download
  • Description updated (diff)
  • Category set to Workbench

The download behavior (re)appeared after enabling keep-web in Workbench config.

Could be a config bug or a Workbench bug.

#5 Updated by Tom Clegg 10 months ago

8113-view-full-log changes link text from "Download" to "View".

The behavior change seems to be a deployment issue: we had neither wildcard DNS/TLS nor trust-all-content, so keep-web refused to serve inline content.

When the undesirable "download" behavior happens, this appears in production.log:

Using download link, even though inline content was requested: https://collections.qr1hi.arvadosapi.com/c=acbd18db4cc2f85cedef654fccc4a4d8-3

#6 Updated by Tom Clegg 10 months ago

  • Status changed from New to In Progress

#7 Updated by Tom Morris 10 months ago

  • Assignee set to Tom Clegg

Assigning to Tom since he marked it as In Progress.

I think this is fixed?

#8 Updated by Bryan Cosca 10 months ago

yep this is fixed!

#9 Updated by Tom Clegg 4 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF