Feature #8333
closed
[SDKs] `arv keep docker` supports `repo:tag` image name scheme
Description
Right now the syntax is arv keep docker repo tag. We can keep supprting that, but adding support for arv keep docker repo:tag would be more like the rest of the Docker universe, including other Arvados Docker references like the job runtime constraint.
Related issues
Updated by Brett Smith about 8 years ago
- Target version set to Arvados Future Sprints
Updated by Brett Smith about 8 years ago
- Subject changed from [SDKs] `arv keep docker` supports `arv keep docker repo:tag syntax` to [SDKs] `arv keep docker` supports `repo:tag` image name scheme
Updated by Nico César over 6 years ago
Jeff Jasper from q^2 bumped into this problem. Can we fix this?
Updated by Tom Morris over 6 years ago
- Target version changed from Arvados Future Sprints to 2017-10-11 Sprint
Updated by Tom Clegg over 6 years ago
8333-docker-repo-tag @ 36e23b3761e43231789df66dc441727c000a2ffc
Updated by Peter Amstutz over 6 years ago
So it turns out that you can specify a port when using a custom registry, e.g. "myregistry.io:8888/repo/image:tag"
Here's how cwltool does it:
sp = dockerRequirement["dockerImageId"].split(":")
if len(sp) == 1:
sp.append("latest")
elif len(sp) == 2:
# if sp[1] doesn't match valid tag names, it is a part of repository
if not re.match(r'[\w][\w.-]{0,127}', sp[1]):
sp[0] = sp[0] + ":" + sp[1]
sp[1] = "latest"
elif len(sp) == 3:
if re.match(r'[\w][\w.-]{0,127}', sp[2]):
sp[0] = sp[0] + ":" + sp[1]
sp[1] = sp[2]
del sp[2]
repository = sp[0]
tag = sp[1]
Updated by Tom Clegg over 6 years ago
Updated & added tests for "host:port/repo/img:tag", "[::1]:port/repo/img", etc.
8333-docker-repo-tag @ 5832cd21b303fcffa4ff84390a046019274bc7cb
Updated by Anonymous over 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:4b4a0917a967c0ec2dd7b72c9665e0859022f120.
Updated by Tom Clegg over 1 year ago
- Related to Bug #19840: Gets confused by port numbers in docker image name added