Bug #8371
closed
[Deployment] Upgrading Rails packages on CentOS uninstalls them
Added by Brett Smith over 8 years ago.
Updated over 7 years ago.
Assigned To:
Javier Bértoli
Description
When yum upgrades a package, it runs the postinst script for the newly installed version, then runs the cleanup script for the previously installed version. Our cleanup script always removes the package, so upgrading a package effectively uninstalls it. The cleanup script needs to recognize the "upgrade from previous version" call, and not clean up anything in that case.
- Target version set to 2016-03-02 sprint
- Assigned To set to Brett Smith
- Status changed from New to In Progress
review @ acab2f7c338f245baa7e5d9dca57476d12d863bf
I don't see a clear reason for the previous " [ "$1" = "1" ] || [ "$1" = "2" ] " . but whatever, LGTM now.
Nico Cesar wrote:
review @ acab2f7c338f245baa7e5d9dca57476d12d863bf
I don't see a clear reason for the previous " [ "$1" = "1" ] || [ "$1" = "2" ] " . but whatever, LGTM now.
I think it was just copied over as boilerplate from the postinst (where it makes more sense). Thanks.
- Status changed from In Progress to Resolved
Applied in changeset arvados-dev|commit:623af8e46e921f59abeeee9e7ae8ec4aef890b5b.
- Status changed from Resolved to New
- Target version changed from 2016-03-02 sprint to Arvados Future Sprints
Still an issue as of the 2016-03-30 packages.
Brett Smith wrote:
Still an issue as of the 2016-03-30 packages.
Actually, this might be mistaken. It might be that the current packages are fine, but the postrm from previously-installed (and buggy) packages runs as you upgrade. If that's the case, there's really no way around this other than to go through, or somehow inhibit the buggy postrm from running.
- Assigned To changed from Brett Smith to Tom Morris
- Assigned To changed from Tom Morris to Javier Bértoli
Javier - can you please review the current state of this and either close or update? Thanks!
- Target version changed from Arvados Future Sprints to 2017-04-12 sprint
- Status changed from New to Closed
Tried on arvagrant, with CentOS 7, deploying first version
20161229114527-997479d1408139e96ecdb42a60b4f727f814f6c9
and then upgrading to version
20170123133526-6441ff0411fc0316c0825e8647150b1e079256ab.
All tests passes, nothing seems to be broken and/or missing, so I guess this is solved now.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Tom Morris 
Updated by Javier Bértoli