Bug #8413

[Deployment] Rails postinst script apparently messes with /etc/arvados directory tree ownerships

Added by Brett Smith almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
Deployment
Target version:
Start date:
02/17/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

On one system it changed the owning group to root where it should've stayed www-data.


Subtasks

Task #8475: Review arvados-dev branch 8413-fix-rails-postinst-chgrp-wipResolvedNico César

Associated revisions

Revision f0a79eee
Added by Brett Smith almost 6 years ago

Merge branch '8413-fix-rails-postinst-chgrp-wip'

Refs #8413. Closes #8475.

Revision f0a79eee
Added by Brett Smith almost 6 years ago

Merge branch '8413-fix-rails-postinst-chgrp-wip'

Refs #8413. Closes #8475.

Revision 623af8e4 (diff)
Added by Brett Smith almost 6 years ago

8371, 8413: Bump Rails package iteration.

Build these bug fixes into new packages.
Closes #8371, #8413.

Revision 623af8e4 (diff)
Added by Brett Smith almost 6 years ago

8371, 8413: Bump Rails package iteration.

Build these bug fixes into new packages.
Closes #8371, #8413.

History

#1 Updated by Brett Smith almost 6 years ago

  • Description updated (diff)

#2 Updated by Brett Smith almost 6 years ago

  • Target version set to 2016-03-02 sprint

#3 Updated by Brett Smith almost 6 years ago

  • Story points set to 0.5

#4 Updated by Brett Smith almost 6 years ago

  • Assigned To set to Brett Smith

#5 Updated by Brett Smith almost 6 years ago

  • Status changed from New to In Progress

#6 Updated by Nico César almost 6 years ago

review @ b6488e3814aea0a97a6912ffb92327030df69e63

LGTM

it got my attention that you switched from logical names to UID/GID
- local ownership="$(stat -c "%U:%G" "$release_conffile")"
+ local ownership="$(stat -c "%u:%g" "$release_conffile")"
was that a safe guard for non-listed users in /etc/groups (a.k.a some docker related problem :) )? this is just curiosity, you should merge

#7 Updated by Brett Smith almost 6 years ago

Nico Cesar wrote:

it got my attention that you switched from logical names to UID/GID
- local ownership="$(stat -c "%U:%G" "$release_conffile")"
+ local ownership="$(stat -c "%u:%g" "$release_conffile")"
was that a safe guard for non-listed users in /etc/groups (a.k.a some docker related problem :) )? this is just curiosity, you should merge

It was to make the gid comparison later in the code easier. It was easier to say [ 0 != "$owning_gid" ] than look up the name of GID 0 and compare. Thanks.

#8 Updated by Brett Smith almost 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados-dev|commit:623af8e46e921f59abeeee9e7ae8ec4aef890b5b.

Also available in: Atom PDF