https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-02-11T22:01:01ZArvadosArvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=351762016-02-11T22:01:01ZWard Vandewegeward@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/35176/diff?detail_id=34480">diff</a>)</li><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=352622016-02-16T16:27:57ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Subject</strong> changed from <i>[Node Manager] missing method on ec2</i> to <i>[Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driver</i></li><li><strong>Assigned To</strong> deleted (<del><i>Peter Amstutz</i></del>)</li><li><strong>Target version</strong> set to <i>2016-03-02 sprint</i></li></ul><p>Either the method needs to be implemented on EC2, or the code in the generic driver needs to be implemented without using this.</p> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=353032016-02-16T19:17:53ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Story points</strong> set to <i>0.5</i></li></ul> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=353932016-02-17T19:53:46ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul><p>Peter already has a branch that removes the find_node call from the generic driver (if I followed correctly).</p> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=357812016-02-26T14:12:31ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=357862016-02-26T15:16:52ZNico César
<ul></ul><p>reviewing 8b5a707a7a84e7fe9391d9c066f6e08f326e22f7</p>
<p>in services/nodemanager/arvnodeman/computenode/driver/__init__.py<br />I see that is a generic "except:" for find_node ( that is not there anymore ) I think we should get rid of that and make the exception explode. Dragons could be hidden under the carpet otherwise. If that except is needed to avoid "re-raising the original create_node exception" then it should be an specific class of exception to be handle.</p>
<pre><code>
try:
node = self.search_for(kwargs['name'], 'list_nodes', self._name_key)
if node:
return node
except:
# Ignore possible exception from find_node in favor of
# re-raising the original create_node exception.
pass
raise
</code></pre>
<p>all the rest LGTM</p> Arvados - Bug #8416: [Node Manager] General compute node driver calls self.find_node - Unimplemented in the EC2 driverhttps://dev.arvados.org/issues/8416?journal_id=358362016-02-29T14:45:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados|commit:c398b7d60aedab0a7b6f99cfee9e631bd66c93cd.</p>