https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-04-05T16:49:32ZArvadosArvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=374042016-04-05T16:49:32ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Target version</strong> set to <i>Arvados Future Sprints</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=518882017-05-18T15:39:33ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Related to this, workbench sharing links should link directly to the keep-web index page.</p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=519932017-05-23T19:05:22ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2017-06-21 sprint</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=522102017-05-30T19:05:37ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/52210/diff?detail_id=50341">diff</a>)</li><li><strong>Story points</strong> set to <i>2.0</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=524362017-06-07T18:26:53ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Idea</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=524802017-06-07T18:59:13ZTom Cleggtom@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=525132017-06-07T20:28:38ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526032017-06-13T12:59:07ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <i>index page 0e3369b.png</i> added</li><li><strong>File</strong> <i>index page 2dc0e00.png</i> added</li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526042017-06-13T13:00:56ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/1713">index.page.2dc0e00.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1713/index.page.2dc0e00.png">index.page.2dc0e00.png</a> added</li><li><strong>File</strong> <a href="/attachments/1714">index.page.0e3369b.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1714/index.page.0e3369b.png">index.page.0e3369b.png</a> added</li></ul><a name="Existing-Workbench-index-page"></a>
<h2 >Existing Workbench index page<br /><img src="https://dev.arvados.org/attachments/download/1714/index.page.0e3369b.png" alt="" /><a href="#Existing-Workbench-index-page" class="wiki-anchor">¶</a></h2>
<a name="new-keep-web-index-page-2dc0e00"></a>
<h2 >new keep-web index page @ <a class="changeset" title="8784: wget args, styling Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/2dc0e004e32b05b69472085600d13af5ef1db86c">2dc0e00</a><br /><img src="https://dev.arvados.org/attachments/download/1713/index.page.2dc0e00.png" alt="" /><a href="#new-keep-web-index-page-2dc0e00" class="wiki-anchor">¶</a></h2>
TODO:
<ul>
<li>use new SDK to load into collection record and cache that, instead of loading/caching a map[string]interface and copying to a Collection in each request</li>
</ul>
TBD:
<ul>
<li>(separate branch) redirect Workbench index page URL to keep-web, and use keep-web directly when generating new links</li>
<li>monospace font change a good idea?</li>
<li>dropping the hierarchy a good idea? if so, maybe only the name should be hotlinked, not the whole path?</li>
<li>rename (*Collection)FileSystem() to ROFileSystem() or HTTPFileSystem() or Snapshot()?</li>
</ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526052017-06-13T13:01:02ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> deleted (<del><i>index page 0e3369b.png</i></del>)</li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526062017-06-13T13:01:06ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> deleted (<del><i>index page 2dc0e00.png</i></del>)</li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526072017-06-13T14:00:50ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/1715">index.page.a42cb73.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1715/index.page.a42cb73.png">index.page.a42cb73.png</a> added</li></ul><a name="at-a42cb73-with-file-sizes"></a>
<h2 >at <a class="changeset" title="8784: Show file sizes. Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/a42cb738abb4f4312651774760b18b2ed1053452">a42cb73</a>, with file sizes<br /><img src="https://dev.arvados.org/attachments/download/1715/index.page.a42cb73.png" alt="" /><a href="#at-a42cb73-with-file-sizes" class="wiki-anchor">¶</a></h2> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526102017-06-13T14:53:57ZTom Cleggtom@curii.com
<ul></ul><p>8784-dir-listings @ <a class="changeset" title="8784: Show file sizes. Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/abf007273ba68c2eb541763e40b19d1703132685">abf007273ba68c2eb541763e40b19d1703132685</a></p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526472017-06-14T15:08:23ZTom Cleggtom@curii.com
<ul></ul>8784-dir-listings @ <a class="changeset" title="8784: Use arvados.Collection in cache. Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/510a92b885ff547dd7eecb34093f27a7245f021f">510a92b885ff547dd7eecb34093f27a7245f021f</a>
<ul>
<li>use new SDK to load into collection record and cache that, instead of loading/caching a map[string]interface and copying to a Collection in each request</li>
</ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=526592017-06-14T19:32:54ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Sorry for the delay, here are some questions:</p>
<ul>
<li>File <code>sdk/go/arvados/collection_fs.go</code>
<ul>
<li>Line 60, 68: Shouldn’t <code>ret</code> be checked if it’s nil before returning? As I read on File’s Readdir doc, if returning an empty slice, it should return a non-nil error.</li>
<li>Line 189: I suppose that empty conditional should be removed, right?</li>
</ul>
</li>
<li>File <code>services/keep-web/handler.go</code>
<ul>
<li>Line 168: Shouldn't that comment line be updated to something like “<code>/c=ID[/PATH…]</code>” to stay in sync with the code?</li>
<li>Lines 323-335: It’s a little difficult (at least for me) to follow that conditionals chain, could you add some comments? I’m specially interested on L329, but in general I feel that for an Open() operation, those are lots of checks, it would be nice to have comments.</li>
<li>Line 402: Couldn’t <code>colllection</code> be retrieved from <code>fs</code> doing type assertion? (to avoid passing it as an argument)</li>
</ul>
</li>
<li>Don’t understand why, but running local tests failed with this:<br /><pre>
# git.curoverse.com/arvados.git/services/keep-web
tmp/GOPATH/src/git.curoverse.com/arvados.git/services/keep-web/handler.go:451: undefined: sort.Slice
</pre></li>
<li>If a collection is empty, is it possible to show some legend stating that fact instead of using the title “File Listing”?</li>
</ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=527122017-06-15T21:26:38ZTom Cleggtom@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Sorry for the delay, here are some questions:</p>
<ul>
<li>File <code>sdk/go/arvados/collection_fs.go</code>
<ul>
<li>Line 60, 68: Shouldn’t <code>ret</code> be checked if it’s nil before returning? As I read on File’s Readdir doc, if returning an empty slice, it should return a non-nil error.</li>
</ul></li>
</ul>
</blockquote>
<p>Yes, updated. If count>0 then an empty slice has to come with an error.</p>
<blockquote>
<ul>
<li>Line 189: I suppose that empty conditional should be removed, right?</li>
</ul>
</blockquote>
<p>Whoops. That can't happen: we would have returned it as a file earlier. Removed.</p>
<blockquote>
<ul>
<li>File <code>services/keep-web/handler.go</code>
<ul>
<li>Line 168: Shouldn't that comment line be updated to something like “<code>/c=ID[/PATH…]</code>” to stay in sync with the code?</li>
</ul></li>
</ul>
</blockquote>
<p>Updated.</p>
<blockquote>
<ul>
<li>Lines 323-335: It’s a little difficult (at least for me) to follow that conditionals chain, could you add some comments? I’m specially interested on L329, but in general I feel that for an Open() operation, those are lots of checks, it would be nice to have comments.</li>
</ul>
</blockquote>
<p>Added comments to the error cases.</p>
<blockquote>
<ul>
<li>Line 402: Couldn’t <code>colllection</code> be retrieved from <code>fs</code> doing type assertion? (to avoid passing it as an argument)</li>
</ul>
</blockquote>
<p>I suppose... turns out the only thing we need from the collection is its name anyway, so I changed that arg to "collectionName string".</p>
<blockquote>
<ul>
<li>Don’t understand why, but running local tests failed with this:<br />[...]</li>
</ul>
</blockquote>
<p>Ah, it seems that was introduced in Go 1.8 -- I <em>thought</em> sorting seemed easier than last time! Updated run-tests.sh and packaging scripts accordingly.</p>
<blockquote>
<ul>
<li>If a collection is empty, is it possible to show some legend stating that fact instead of using the title “File Listing”?</li>
</ul>
</blockquote>
<p>Done.</p>
<p>8784-dir-listings @ <a class="changeset" title="8784: Update to Go 1.8.3. Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/f77d63e6cfaf7278c1cb0fb05e5a4e3f45320e3a">f77d63e6cfaf7278c1cb0fb05e5a4e3f45320e3a</a></p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=527342017-06-16T16:25:39ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>LGTM!</p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=528342017-06-21T15:38:17ZTom Cleggtom@curii.com
<ul></ul>8784-dir-listings @ <a class="changeset" title="8784: Fix service discovery race in tests (send SIGHUP to keep-web). Arvados-DCO-1.1-Signed-off-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/6c51f11ab5affb4023762227ffb53a5be11a1003">6c51f11ab5affb4023762227ffb53a5be11a1003</a>
<ul>
<li>Workbench redirects to keep-web (if available) instead of serving its own directory listing page.</li>
<li>passed <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/342/">https://ci.curoverse.com/job/developer-run-tests/342/</a></li>
</ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=528652017-06-21T18:36:40ZTom Cleggtom@curii.com
<ul><li><strong>Subject</strong> changed from <i>[Keep-web] Generate directory listings</i> to <i>[Workbench] Use keep-web to generate directory listings</i></li><li><strong>Story points</strong> changed from <i>2.0</i> to <i>0.5</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=528662017-06-21T18:36:46ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2017-06-21 sprint</i> to <i>2017-07-05 sprint</i></li></ul> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=530742017-06-27T20:17:28ZTom Cleggtom@curii.com
<ul></ul><p>8784-dir-listings @ <a class="changeset" title="8784: Link directly to keep-web when sharing collections. Arvados-DCO-1.1-Signed-off-by: Tom Cle..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/ff723f5f08e286df4c4c58a27a9db574ca604a6f">ff723f5f08e286df4c4c58a27a9db574ca604a6f</a> -- passed <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/356/">https://ci.curoverse.com/job/developer-run-tests/356/</a></p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=531302017-06-29T16:00:31ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>What's the rationale for using query_token instead of path_token?</p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=531732017-06-30T19:41:51ZTom Cleggtom@curii.com
<ul></ul><p>Peter Amstutz wrote:</p>
<blockquote>
<p>What's the rationale for using query_token instead of path_token?</p>
</blockquote>
<p>None -- changed to path_token.</p>
<p>Also added a fix to make the "upload / network error" integration test pass with the latest Firefox.</p>
<p>8784-dir-listings @ <a class="changeset" title="8784: Fix test for latest firefox. Given "http://host:99999/path", Firefox 54 returns an error "..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353">e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353</a></p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=531832017-07-03T14:07:25ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>LGTM @ <a class="changeset" title="8784: Fix test for latest firefox. Given "http://host:99999/path", Firefox 54 returns an error "..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353">e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353</a></p> Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingshttps://dev.arvados.org/issues/8784?journal_id=532302017-07-05T19:03:08ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul>