Arvados

In queue.go, the metadata looks like this

type QueueMetadataResponse struct {
    ApproximateMessageCount int
    UserDefinedMetadata     map[string]string
}

Can we make the blob metadata work the same way, something like this...?

type Blob struct {
    Name       string            `xml:"Name"`
    Properties BlobProperties    `xml:"Properties"`
    Metadata   map[string]string `xml:"Metadata"`
}

This way callers could say resp.Blobs[0].Metadata["Foo"] instead of iterating over a slice and comparing keys.

I couldn't find a way to make encoding/xml do this by itself, but if we make a BlobMetadata type that implements xml.Unmarshaler, we can convert it to a map while decoding, so blobs[i].Metadata["Foo"] works out of the box:

https://play.golang.org/p/P1xi66oeJw

Tom, thanks for the update. It's more appropriate implementation. I updated the test accordingly.

This looks better, thanks.

IMO the test case is verbose, making it less obvious what it's doing. How about something like this:

var expectMeta map[string]BlobMetadata

for i := 0; i < 5; i++ {
    name := randString(20)
    c.Assert(cli.putSingleBlockBlob(cnt, name, []byte("Hello, world!")), chk.IsNil)
    c.Assert(cli.SetBlobMetadata(cnt, name, map[string]string{
        "foo": name,
        "bar_BAZ": "waz qux",
    }), chk.IsNil)
    expectMeta[name] = BlobMetadata{
        "Foo": name,
        "Bar_baz": "waz qux",
    }
}

// ...call ListBlobs and copy results into respBlobs...

for name, metadata := range expectMeta {
    c.Check(respBlobs[name].Metadata, chk.DeepEquals, expectMeta[name])
}

I'd also say skip the cli.GetBlobMetadata() call and the associated checks. That stuff is already tested by TestGetAndSetMetadata().

(sort.Strings(blobs) seems superfluous too)

Might be worth writing one blob without metadata, if only for the sake of exercising that case in the decoder.

c.Check(0, chk.Equals, len(respBlobs[nameWithoutMetadata].Metadata))

Tom:

• Updated the test as suggested and added a blob with no metadata

• While testing I realized that the metadata returned by ListBlobs should match the same behavior as GetBlobMetadata, where the keys are in lowercase. Made this update in blob.go as well.

Thanks.

golint: blob_test.go:552:12: should omit 2nd value from range; this loop is equivalent to `for name := range ...`

With that fixed, LGTM @ commit:c922124. Should probably squash this into one commit before making a PR, to make it easier for upstream to review...