Arvados

Ready for review: https://dev.arvados.org/projects/arvados/wiki/Pipeline_template_development

We should not include "arvados_sdk_version" in the main example given the reported bugs in installing it. Mentioning it and stating that it's a good idea to require the arvados sdk to be installed in the docker image.

It would be awesome to connect the script_parameters (required, default, dataclass) with the effects they have on the workbench view (from a user's perspective).

I've updated the wiki to remove arvados_sdk_version and added screenshots for script_parameters.

Feel free to link to this page if it will help you at all: https://dev.arvados.org/projects/arvados/wiki/Writing_a_Script_Calling_a_Third_Party_Tool

We currently are missing a description of "components" in this page, which are a fairly large part of pipeline templates. Simply adding a paragraph saying that pipeline templates are composed of a dictionary of components and that each component maps to a job would be helpful. We can then state that the rest of the document describes the specific pieces of a component.

The main example still has arvados_sdk_version defined.

The introductory paragraph under "Writing script parameters" should talk about the "required" flag so it doesn't come as a surprise later.

"yields this example" is fairly vague. Saying that a particular pipeline template yields a pipeline instance is more specific and accurate.

How does a dataclass "File" influence the view? What about the dataclass "number"?

The following is inconsistent enough to be confusing:

The inputs tab in the pipeline instance page shows all the required parameters.
...
For the 'additional_params' parameter, since its not required, its in the 'Components' tab, where you can set it:

Maybe try?

The "Inputs" tab in the pipeline instance page shows all the required parameters.
...
The "Components" tab in the pipeline instance page shows all the parameters. Thus it is the only place where non-required parameters, such as 'additional_params' may be set.

Why is "read_group" highlighted in red in the Components tab, but nothing else is? That will likely be distracting to a new viewer.

One runtime constraint is docker_image.

What does docker_image control? You describe hints for it, but don't say what it actually does. Is it required? What needs to be in the docker image?

The max_tasks_per_node parameter will allow you to allocate more computations on your node

What are "computations"? We need to use more specific language here. What happens if max_tasks_per_node is equal to 2? When will multiple jobs be scheduled on that node? When will multiple tasks be scheduled on that node?

Why is "read_group" highlighted in red in the Components tab, but nothing else is? That will likely be distracting to a new viewer.

I don't know. I could hack it by making the template set it as false, but this is what it looks like when a Text/number parameter is 'required'.

Everything else has been added.

Alright, I'm happy with this. Brett is up next.

resolving due to time constraints and brett does not have time to review and sally reviewed already