Bug #8963

[SDKs] `arv keep docker` loses image_timestamp in metadata links when copying between projects

Added by Brett Smith about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Brett Smith
Category:
-
Target version:
Start date:
04/28/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

See where make_link is called under if not args.force in main().


Subtasks

Task #9110: Review 8963-arv-copy-link-properties-wipResolvedBrett Smith


Related issues

Related to Arvados - Feature #8962: Enable copying docker images from one project to another on a single clusterClosed04/13/2016

Associated revisions

Revision 3ede45e6
Added by Brett Smith about 5 years ago

Merge branch '8963-arv-copy-link-properties-wip'

Closes #8963, #9110.

History

#1 Updated by Brett Smith about 5 years ago

  • Target version set to Arvados Future Sprints

#2 Updated by Tom Clegg about 5 years ago

  • Story points set to 0.5

#3 Updated by Brett Smith about 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Brett Smith
  • Target version changed from Arvados Future Sprints to 2016-05-11 sprint

#4 Updated by Brett Smith about 5 years ago

Branch is up for review. 4xphq-4zz18-2pcoar2p0xwb5x8 was created by re-uploading arvados/jobs using the code in the branch.

#5 Updated by Tom Clegg about 5 years ago

3c2b7eb LGTM, thanks. Looks like you fixed some paging bugs too by using _get_docker_links().

#6 Updated by Brett Smith about 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:3ede45e668eaad4cb23cc11f11a1a7ea6e688c88.

#7 Updated by Brett Smith about 5 years ago

Tom Clegg wrote:

3c2b7eb LGTM, thanks. Looks like you fixed some paging bugs too by using _get_docker_links().

Yes. It's also directly relevant to the bug, because _get_docker_links() sorts link objects in the same order the API server would prioritize them. This means that if there's any link with an image_timestamp property, we're guaranteed to use it.

Also available in: Atom PDF