Bug #8963: [SDKs] `arv keep docker` loses image_timestamp in metadata links when copying between projects - Arvados

Actions

Bug #8963

closed

[SDKs] `arv keep docker` loses image_timestamp in metadata links when copying between projects

Added by Brett Smith almost 9 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Category:

-

Target version:

2016-05-11 sprint

Story points:

0.5

Description

See where make_link is called under if not args.force in main().

Subtasks 1 (0 open — 1 closed)

Related issues 1 (0 open — 1 closed)

Actions

#1

Updated by Brett Smith almost 9 years ago

Target version set to Arvados Future Sprints

Actions

#2

Updated by Tom Clegg almost 9 years ago

Story points set to 0.5

Actions

#3

Updated by Brett Smith almost 9 years ago

Status changed from New to In Progress
Assigned To set to Brett Smith
Target version changed from Arvados Future Sprints to 2016-05-11 sprint

Actions

#4

Updated by Brett Smith almost 9 years ago

Branch is up for review. 4xphq-4zz18-2pcoar2p0xwb5x8 was created by re-uploading arvados/jobs using the code in the branch.

Actions

#5

Updated by Tom Clegg almost 9 years ago

3c2b7eb LGTM, thanks. Looks like you fixed some paging bugs too by using _get_docker_links().

Actions

#6

Updated by Brett Smith almost 9 years ago

Status changed from In Progress to Resolved
% Done changed from 0 to 100

Applied in changeset arvados|commit:3ede45e668eaad4cb23cc11f11a1a7ea6e688c88.

Actions

#7

Updated by Brett Smith almost 9 years ago

Tom Clegg wrote:

3c2b7eb LGTM, thanks. Looks like you fixed some paging bugs too by using _get_docker_links().

Yes. It's also directly relevant to the bug, because _get_docker_links() sorts link objects in the same order the API server would prioritize them. This means that if there's any link with an image_timestamp property, we're guaranteed to use it.

Actions

Also available in: Atom PDF