Arvados

Please take over 9132-dockerclient

• Replace API calls to equivalent ones, see https://godoc.org/github.com/docker/docker/client
• Update stubs used by tests
• Once it compiles & tests pass, run integration tests using arvbox and "arvados-cwl-runner --api=containers"

Branch 9132-dockerclient @ 374dff075f0d2961b3843d952ccca9f55d972e9a

• Uses new docker client API.

• What ContainerStartOptions should we use?

• The ContainerWait method returns an int64 and hence I replaced the waitDocker chan as such.

• The test "TestStopOnSignal" is failing sometimes when the whole crunch-run test set is executed with the error “cannot allocate memory” locally, but it appears that it is an issue with development env and passing consistently in jenkins

Thanks.

Radhika Chippada wrote:

• What ContainerStartOptions should we use?

Empty LGTM. The options seem to be for checkpoint suspend/resume -- sounds interesting, but we're not using it.

• The ContainerWait method returns an int64 and hence I replaced the waitDocker chan as such.

nit: could change the "finish" field and the "exitCode" arguments too, then the int64() cast wouldn't be needed.

• The test "TestStopOnSignal" is failing sometimes when the whole crunch-run test set is executed with the error “cannot allocate memory” locally, but it appears that it is an issue with development env and passing consistently in jenkins

Tried run-tests.sh --repeat 20, no problems.

LGTM, thanks!

I'm running stuff and getting an exit code of "2" when it should be "0". I think maybe the return code from ContainerWait is not being interpreted properly?

I think maybe the return code from ContainerWait is not being interpreted properly

We are just returning what is returned by ContainerWait and so we don't have any interpretation happening.

However, according to https://docs.docker.com/engine/reference/run/#exit-status , which takes me to http://tldp.org/LDP/abs/html/exitcodes.html , it could be that we are not configuring the client correctly.

This stackflow page led me to the above links: http://stackoverflow.com/questions/31297616/what-is-the-authoritative-list-of-docker-run-exit-codes

Yea, that might be the legitimate exit code. But the CWL test should pass, and it isn't, so it needs further investigation.